Opened 6 years ago
Closed 6 years ago
#18328 closed defect (fixed)
Dijit dialog should register dummy error callbacks to the animation deferreds
Reported by: | Jared Jurkiewicz | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.11 |
Component: | Dijit | Version: | 1.10.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Dijit dialog should register dummy error callbacks to the animation deferreds. This will silence the spew of 'CancelError?' in the console if you happen to destroy a dialog in the middle of the fade-out. The Dialog code is canceling the animation, which is fine and proper, but because it doesn't have an error callback to call, the Deferred/promise spews this cancel to the console. It would be really nice if that were silenced. It can be done as simple as:
destroy: function(){ if(this._fadeInDeferred){ // XWT add of the dummy functions to silence the CancelError that the deferred logs. this._fadeInDeferred.then(function(){}, function(){}); this._fadeInDeferred.cancel(); } if(this._fadeOutDeferred){ // XWT add of the dummy functions to silence the CancelError that the deferred logs. this._fadeOutDeferred.then(function(){}, function(){}); this._fadeOutDeferred.cancel(); } if(this._moveable){ this._moveable.destroy(); } var h; while(h = this._modalconnects.pop()){ h.remove(); } DialogLevelManager.hide(this); this.inherited(arguments); } });
Change History (3)
comment:1 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 6 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
comment:3 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
I think the console messages only occur in debug mode but sure, I can add that.