Dijit dialog should register dummy error callbacks to the animation deferreds

[Jared Jurkiewicz]

Dijit dialog should register dummy error callbacks to the animation deferreds. This will silence the spew of 'CancelError?' in the console if you happen to destroy a dialog in the middle of the fade-out. The Dialog code is canceling the animation, which is fine and proper, but because it doesn't have an error callback to call, the Deferred/promise spews this cancel to the console. It would be really nice if that were silenced. It can be done as simple as:

		destroy: function(){
			if(this._fadeInDeferred){
				// XWT add of the dummy functions to silence the CancelError that the deferred logs.
				this._fadeInDeferred.then(function(){}, function(){});
				this._fadeInDeferred.cancel();
			}
			if(this._fadeOutDeferred){
				// XWT add of the dummy functions to silence the CancelError that the deferred logs.
				this._fadeOutDeferred.then(function(){}, function(){});
				this._fadeOutDeferred.cancel();
			}
			if(this._moveable){
				this._moveable.destroy();
			}
			var h;
			while(h = this._modalconnects.pop()){
				h.remove();
			}

			DialogLevelManager.hide(this);

			this.inherited(arguments);
		}
	});

[bill]

I think the console messages only occur in debug mode but sure, I can add that.

[Bill Keese <[email protected]…>]

In 69d1440c91d0364dd27c152f2c82d9205e1d6ff8/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?