Opened 5 years ago

Closed 4 years ago

#18328 closed defect (fixed)

Dijit dialog should register dummy error callbacks to the animation deferreds

Reported by: Jared Jurkiewicz Owned by: bill
Priority: undecided Milestone: 1.11
Component: Dijit Version: 1.10.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Dijit dialog should register dummy error callbacks to the animation deferreds. This will silence the spew of 'CancelError?' in the console if you happen to destroy a dialog in the middle of the fade-out. The Dialog code is canceling the animation, which is fine and proper, but because it doesn't have an error callback to call, the Deferred/promise spews this cancel to the console. It would be really nice if that were silenced. It can be done as simple as:

		destroy: function(){
			if(this._fadeInDeferred){
				// XWT add of the dummy functions to silence the CancelError that the deferred logs.
				this._fadeInDeferred.then(function(){}, function(){});
				this._fadeInDeferred.cancel();
			}
			if(this._fadeOutDeferred){
				// XWT add of the dummy functions to silence the CancelError that the deferred logs.
				this._fadeOutDeferred.then(function(){}, function(){});
				this._fadeOutDeferred.cancel();
			}
			if(this._moveable){
				this._moveable.destroy();
			}
			var h;
			while(h = this._modalconnects.pop()){
				h.remove();
			}

			DialogLevelManager.hide(this);

			this.inherited(arguments);
		}
	});

Change History (3)

comment:1 Changed 4 years ago by bill

Description: modified (diff)

comment:2 Changed 4 years ago by bill

Milestone: tbd1.11
Owner: set to bill
Status: newassigned

I think the console messages only occur in debug mode but sure, I can add that.

comment:3 Changed 4 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 69d1440c91d0364dd27c152f2c82d9205e1d6ff8/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.