Opened 5 years ago

Closed 4 years ago

#18323 closed defect (fixed)

dojox.image.LightboxNano reference doc examples broken

Reported by: schindlerjiri Owned by: Simon Speich
Priority: undecided Milestone: 1.11
Component: Documentation Version: 1.10.2
Keywords: Cc:
Blocked By: Blocking:

Description

Hello,

it looks like from version 1.10.0 dojox.image.LightboxNano? is not working well.

It needs to load dojo/dojox/image/resources/LightboxNano.css manually.

Till that version it wasn't needed to do so and all styles were set inside dojo/dojox/image/LightboxNano.js.

Change History (6)

comment:1 Changed 4 years ago by Wouter Hager

I can confirm this. The style attribute is not set (correctly) by the widget. These changes were made 1.9.3 (https://github.com/dojo/dojox/commit/cd3aca827f9a0a1572fc8ac5da5db7fccfd1150c) but the reference guide has not been updated to reflect these changes.

comment:2 Changed 4 years ago by bill

Component: DojoxDocumentation
Owner: set to Simon Speich
Status: newassigned
Summary: dojox.image.LightboxNanodojox.image.LightboxNano reference doc examples broken

Simon, can you fix the reference doc? It was broken by your #12202 change.

Last edited 4 years ago by bill (previous) (diff)

comment:3 Changed 4 years ago by Simon Speich

Yes I'll update the documentation this weekend.

comment:4 Changed 4 years ago by bill

OK thanks!

comment:5 Changed 4 years ago by Simon Speich

The reference docs are fixed accordingly and updated to AMD: http://livedocs.dojotoolkit.org/dojox/image/LightboxNano

Also the code examples should work now.

comment:6 Changed 4 years ago by bill

Milestone: tbd1.11
Resolution: fixed
Status: assignedclosed

Thanks!

Note: See TracTickets for help on using tickets.