#18316 closed defect (fixed)
resizing of dijitDialog with dijitDialogPaneActionBar
Reported by: | gerhard presser | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.10.4 |
Component: | Dijit | Version: | 1.10.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
we are using the dijit/Dialog to display a large form. to save the data there buttons on the bottom of the dialog wrapped in dijitDialogPaneActionBar as described in e.g. http://dojotoolkit.org/reference-guide/1.10/dijit/Dialog.html
if the browser window gets resized and the dialog doesn't fit any more, the first thing to disapear is the dijitDialogPaneActionBar.
we where able to reproduce this issue with nick nisi at the london workshops using dojo's new ConfirmDialog?.
just show the dialog and then resize your browser-window till the dialog barely fits.
we could track it down to somewhere in dijit/layout/utils#layoutChildren() where just the content and the title-bar are used to calculate dimensions.
Change History (8)
comment:1 Changed 6 years ago by
Component: | General → Dijit |
---|---|
Milestone: | tbd → 1.11 |
Owner: | set to bill |
Status: | new → assigned |
comment:2 Changed 6 years ago by
comment:4 Changed 6 years ago by
Milestone: | 1.11 → 1.10.4 |
---|
comment:5 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
There are actually two cases here.
In the old style of using
dijitDialogPaneActionBar
, like in the example on http://dojotoolkit.org/reference-guide/1.10/dijit/Dialog.html, thedijitDialogPaneActionBar
is insidethis.containerNode
, so you get one scrollbar oncontainerNode
and you need to scroll down to get to the buttons. Not ideal, but hard to improve.For ConfirmDialog? (and widgets with similar templates) you are right that
Dialog#resize()
should takethis.actionBarNode
into account too, sincethis.actionBarNode
is a sibling ofthis.containerNode
.I will address the second issue, so that the buttons will always be visible and the scrollbar will just be on
this.containerNode
.I suggest that if you haven't already, then after getting this fix that you subclass Dialog in the same way that ConfirmDialog? does, defining
actionBarTemplate
with yourdijitDialogPaneActionBar
code snippet. That's so the actionBarNode becomes a sibling of containerNode.