Opened 5 years ago

Closed 5 years ago

#18314 closed defect (fixed)

Example for dojo/on has incorrect argument mapping to require statement

Reported by: Carmelo Woodgett Owned by: dylan
Priority: high Milestone: 1.8.10
Component: Documentation Version: 1.10.1
Keywords: Cc:
Blocked By: Blocking:

Description

This:

define(["dojo/on"], function(listen){
    on(button, "click", clickHandler);
	...

Should either be:

define(["dojo/on"], function(on){
    on(button, "click", clickHandler);
	...

OR

define(["dojo/on"], function(listen){
    listen(button, "click", clickHandler);
	...

Change History (2)

comment:1 Changed 5 years ago by dylan

Owner: set to dylan
Priority: undecidedhigh
Status: newassigned

Go with the first one...

comment:2 Changed 5 years ago by dylan

Milestone: tbd1.8.10
Resolution: fixed
Status: assignedclosed

Fixed via 1e0b71ddaf402d06dd916ce3e7009f3ab774b5dc

Backported to 1.10 ( f4fef7077dde783156c1ddd3b06464d236e5537c ), 1.9 ( 2dfbbaf6cf6a7587dec3ab2dedd159782210ab28 ), and 1.8 ( 7199349272da65950ba301758a45e80fc650487a )

Note: See TracTickets for help on using tickets.