Changes between Initial Version and Version 1 of Ticket #18311, comment 2


Ignore:
Timestamp:
Oct 17, 2014, 8:47:32 PM (6 years ago)
Author:
ben hockey
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18311, comment 2

    initial v1  
    1 setters and getters are not the same between `dojo/Stateful` and `dijit/_WidgetBase`.  the getter is definitely called as part of `set` (https://github.com/dojo/dojo/blob/5904b65a6b23ec3192290bfa6f761ba2d26179dc/Stateful.js#L116) when using `dojo/Stateful` - this is working as intended so that the old value can be passed to the setter.
     1setters and getters are not the same between `dojo/Stateful` and `dijit/_WidgetBase`.  the getter is definitely called as part of `set` (https://github.com/dojo/dojo/blob/5904b65a6b23ec3192290bfa6f761ba2d26179dc/Stateful.js#L116) when using `dojo/Stateful` - this is working as intended so that the old value can be passed to the watchers.
    22
    33dylan - do you think it should be different?  it's likely not something that can be changed in dojo 1.x now.