Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#18300 closed defect (fixed)

[patch] NumberSpinner and Slider grab focus on mouse wheel event

Reported by: stefan_t Owned by: bill
Priority: undecided Milestone: 1.9.8
Component: Dijit - Form Version: 1.8.7
Keywords: Cc:
Blocked By: Blocking:

Description

When scrolling with the mouse wheel over an unfocused number spinner it grabs focus and changes the value by scrolling through the available numbers.

This is problematic when using the mouse wheel to scroll a long form and the cursor passes over a number spinner. Then the number spinner starts scrolling instead of the form, which leads to a value change in the spinner.

Attachments (1)

Don_t_simulate_key_press_when_scroll_wheel_events_occurs_unless_already_focused.patch​ (7.2 KB) - added by stefan_t 5 years ago.
Patch to dijit/form/_Spinner on the 1.8 branch

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by stefan_t

Attachment: Don_t_simulate_key_press_when_scroll_wheel_events_occurs_unless_already_focused.patch​ added

Patch to dijit/form/_Spinner on the 1.8 branch

comment:1 Changed 4 years ago by dylan

Milestone: tbd → 1.11
Owner: set to bill
Status: new → assigned

Very simple patch, probably worth reviewing and landing, or explaining why we won't accept (if that's the case)

comment:2 Changed 4 years ago by bill

Summary: dijit/form/NumberSpinner grabs focus on mouse wheel event → NumberSpinner and Slider grab focus on mouse wheel event

OK, I'll land a modified version, thanks Stefan for the patch.

comment:3 Changed 4 years ago by dylan

Summary: NumberSpinner and Slider grab focus on mouse wheel event → [patch] NumberSpinner and Slider grab focus on mouse wheel event

comment:4 Changed 4 years ago by Bill Keese <bill@…>

Resolution: → fixed
Status: assigned → closed

In 1a46e3b1ae1f02fcf75acad93c7bcf22b10f1d6f/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:5 Changed 4 years ago by Bill Keese <bill@…>

In 1aa4e894cf3ebaddd7d66f489f6f48a78945c6c4/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:6 Changed 4 years ago by Bill Keese <bill@…>

In 2500d4980fb6c707135047ac0b23657c7e2569d6/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:7 Changed 4 years ago by bill

Milestone: 1.11 → 1.9.8
Note: See TracTickets for help on using tickets.