#18253 closed defect (fixed)
[regression] Dialog: requires titleBar
Reported by: | floerke | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.10.4 |
Component: | Dijit | Version: | 1.10.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Since version 1.10 the dijit.Dialog requires this.titleBar to be not null.
The new resize-method of dijit.Dialog fails in Firefox, if there is no titleBar (for example in the derived dojox.image.LightboxDialog?).
The titleBar is treated as an optional element in _setup-method (version 1.10) and in in general before 1.10:
if(this.titleBar && this.draggable) ...
But the resize-method states:
array.forEach([this.domNode, this.containerNode, this.titleBar], function(node) { domStyle.set(node, { position: "static", width: "auto", height: "auto" }); } );
and
utils.layoutChildren(this.domNode, contentDim,[Node: this.titleBar, region: "top"}, centerSize ]);
which fails, if this.titleBar is null.
The two calls can be fixed as
array.forEach([this.domNode, this.containerNode, this.titleBar], function(node){ if (node){ domStyle.set(node, { position: "static", width: "auto", height: "auto" }); } });
and
if (this.titleBar){ utils.layoutChildren(this.domNode, contentDim, [ {domNode: this.titleBar, region: "top"}, centerSize ]); }
Change History (7)
comment:1 Changed 7 years ago by
comment:2 Changed 6 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
comment:3 Changed 6 years ago by
Milestone: | 1.11 → 1.10.4 |
---|
comment:4 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:5 Changed 6 years ago by
Summary: | dijit.Dialog requires titleBar → [regression] Dialog: requires titleBar |
---|
comment:6 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
This is easy to reproduce using the one of the test files: