[regression] Dialog: requires titleBar

[floerke]

Since version 1.10 the dijit.Dialog requires this.titleBar to be not null.

The new resize-method of dijit.Dialog fails in Firefox, if there is no titleBar (for example in the derived dojox.image.LightboxDialog?).

The titleBar is treated as an optional element in _setup-method (version 1.10) and in in general before 1.10:

if(this.titleBar && this.draggable)
...

But the resize-method states:

array.forEach([this.domNode, this.containerNode, this.titleBar], 
  function(node)  {
    domStyle.set(node, {
      position: "static",
      width: "auto",
      height: "auto"
    });
  }
);

and

utils.layoutChildren(this.domNode, contentDim,[Node: this.titleBar, region: "top"}, centerSize ]);

which fails, if this.titleBar is null.

The two calls can be fixed as

array.forEach([this.domNode, this.containerNode, this.titleBar], function(node){
  if (node){
    domStyle.set(node, {
      position: "static",
      width: "auto",
      height: "auto"
    });
  }
});

and

if (this.titleBar){
  utils.layoutChildren(this.domNode, contentDim,
    [ {domNode: this.titleBar, region: "top"}, centerSize ]);
}

[Yasir Assam]

This is easy to reproduce using the one of the test files:

• Open dojox/image/tests/test_Lightbox.html in your browser
• Bring up a lightbox image, e.g. click on "tall", or "4:3 image"
• Slowly resize window by gradually making it smaller
• As soon as the window gets too small for the lightbox widget the lightbox widget disappears and you get a bunch of JS errors in the console.

[Bill Keese <[email protected]…>]

In 7fb5165e195a0c3698bd6cde7d93cfa4d5ea5066/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In e1c476f1dc3ca67d9d9029bf46c09900283d19e0/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?