lang.js fix up the isAlien and _toArray

[[email protected]…]

Hi sir, I have two question as following

(1) isAlien will return true if it is a built in function, but the source file of this method, why it has a !lang.isFunction(it)?

isAlien: function(it){
return it && !lang.isFunction(it) && /\{\s*\[native code\]\s*\}/.test(String(it)); // Boolean
}

(2) IE9 and above browser can cover the HTMLCollection to Javascript object, In the source, it will call the slow function.

_toArray: has("ie") ?
			(function(){
				function slow(obj, offset, startWith){
					var arr = startWith||[];
					for(var x = offset || 0; x < obj.length; x++){
						arr.push(obj[x]);
					}
					return arr;
				}
				return function(obj){
					return ((obj.item) ? slow : efficient).apply(this, arguments);  //IE 9 and above, will call the slow function
				};
			})() : efficient,

[mdlabrec]

Pull request for isAlien issue: ​https://github.com/dojo/dojo/pull/123

[bill]

As I wrote in the PR, ISTM that isAlien() is obeying it's spec, which implies that it returns false for normal functions.

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

[dylan]

Closing this as wontfix, but please reopen if there's a new patch that addresses feedback.