Opened 5 years ago

Last modified 23 months ago

#18234 assigned defect

[regression] JSON-RPC-2.0 with unnamed parameters is broken

Reported by: wglas Owned by: dylan
Priority: high Milestone: 1.14
Component: RPC Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description

The fix for ticket #16153 breaks our JAVA and C++-based JSON-RPC services, which are based on JSON-RPC 2.0 but do not support named method parameters.

According to

http://dojotoolkit.org/reference-guide/1.10/dojox/rpc/smd.html#dojox-rpc-smd

the client must issue a call with ordered parameters.

However, a call with an object containing the first parameter and an 'undefined' key is issued.

It turns out, that the code in Service.js does not check, whether the parameters in the SMD specify a name. Hence, na named parameter call is unconditionally enforced, when 'namedParams: true' is set in the envelopeRegistry.

Change History (4)

comment:1 Changed 5 years ago by bill

Owner: set to dylan
Status: newassigned
Summary: JSON-RPC-2.0 with unnamed parameters is broken[regression] JSON-RPC-2.0 with unnamed parameters is broken

Assigning to Dylan since he checked in the fix for #16153.

comment:2 Changed 5 years ago by dylan

Milestone: tbd1.11
Priority: undecidedhigh

@wglas , do you have a patch you might want to contribute per the contributing guidelines at https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md ?

comment:3 Changed 4 years ago by dylan

Milestone: 1.111.12

comment:4 Changed 23 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.