Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18232 closed defect (fixed)

onChange incorrectly fired for widget using _ToggleButtonMixin (ToggleButton, Checkbox, RadioButton)

Reported by: Colin Snover Owned by: Colin Snover
Priority: undecided Milestone: 1.8.7
Component: Dijit - Form Version: 1.8.5
Keywords: Cc:
Blocked By: Blocking:

Description

_ToggleButtonMixin fails to set the lastValueReported/resetValue properties at construction time, unlike widgets that inherit from _FormValueMixin. This means that the first time a form or form widget is reset that uses _ToggleButtonMixin, an invalid onChange event is fired even if the value has not changed from the initial state.

This problem exists back to at least 1.7.

Patch forthcoming.

Change History (5)

comment:1 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: newclosed

In 2a0b9c71240e02b1c4a3c845147f5f154b3acb78/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:2 Changed 5 years ago by Colin Snover <github.com@…>

In 4708fd0deed617dfd13701f9a88de7eab4841129/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 5 years ago by Colin Snover <github.com@…>

In 2249e397bd14ffab66d9fc8753ff234a82d2c09a/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Colin Snover

Milestone: 1.7.61.8.7
Version: 1.7.51.8.5

It became too thorny to backport this past 1.8; there was obviously some refactoring from 1.7 to 1.8.

comment:5 Changed 5 years ago by Colin Snover <github.com@…>

In eb2117888cd3088ffbed8785a66002dbbeb10e66/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.