Using subwidgets with widgetsInTemplate fails in Safari 2.0.4

[guest]

Rendering of subwidgets (using the new widgetsInTemplate property) fails using Safari 2.0.4, the version of Safari currently shipping with OSX.

Open ​http://archive.dojotoolkit.org/nightly/tests/widget/test_widgetsInTemplate.html using Safari to reproduce.

This appears to be fixed in the latest Webkit nightlies, available here: ​http://nightly.webkit.org/

[liucougar]

someone out there wants to workaround the issue for the "old" safari?

or shall we just leave it as the nightly is already working

[dylan]

If anything in the core toolkit relies on it, we need to support it. If not, we need to warn people that use it, and add a note to the release notes, and push to 0.5 at which point we can look to maybe find an easy fix.

[liucougar]

that depends on how you define "core toolkit"

afaik, only dialogs in editor2 make use of this feature

[alex]

I'm pretty sure we can't punt on this. We're shipping a property that people are relying on and it's not marked experimental. Please fix.

[liucougar]

as I said, I have no access to safari

someone wants to adopt this?

[liucougar]

pass to bill

[Adam Peller]

The "DOM Exception 5" comes from DomWidget?.js in postInitialize(). The call to setAttribute('_isSubWidget') fails, apparently because of the underscore. Renaming these references eliminates the exception, but the subContainer is not found, as this.domNode seems to be pointing at the widget node itself rather than the template. That's as far as I got tonight. Hopefully this will make more sense to someone else.

[bill]

that's interesting about the underscore, but as to why this.domNode points to a widget... that's pretty weird. Although maybe it has something to do w/​http://article.gmane.org/gmane.comp.web.dojo.devel/3671/match=parse+createcomponentfromscript and also see ​http://trac.dojotoolkit.org/changeset/4971

[Adam Peller]

(In [6793]) Fix "DOM Exception 5" on Safari. References #1822

[Adam Peller]

(In [6794]) Fix "DOM Exception 5" on Safari. References #1822

[alex]

(In [6795]) Safari handles the <xmp> element differently than other browsers. Fixes #1822

[(none)]

Milestone 0.4.1 deleted