Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18200 closed defect (fixed)

[regression] missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker

Reported by: kenlau Owned by: Bill Keese <bill@…>
Priority: undecided Milestone: 1.10.1
Component: Dijit Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description

The property of visibleRange is missing from TimePicker? in 1.10.0. Our code extends TimePicker? and made use of the visibleRange. Because of the missing property which then fails to display the drop down list for time picker.

Change History (12)

comment:1 Changed 5 years ago by bill

The visibleRange feature is addressed in https://github.com/dojo/dijit/pull/60.

Because of the missing property which then fails to display the drop down list for time picker.

It doesn't display at all? As usual, you'll need to attach a test case to show that problem.

comment:2 Changed 5 years ago by bill

#18220 is a duplicate of this ticket.

comment:3 Changed 5 years ago by kenlau

Have discussed with our architect, we need to get it fixed in 1.10.0 instead of 1.10.1. Thanks.

comment:4 Changed 5 years ago by bill

Milestone: tbd1.10.1
Summary: missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker[regression] missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker

Well, that's impossible without using a time machine to go backwards in time. But I'll mark it for 1.10.1.

comment:5 Changed 5 years ago by bill

Newer pull request, superceding old one: ​https://github.com/dojo/dijit/pull/65.

comment:6 Changed 5 years ago by Bill Keese <bill@…>

Owner: set to Bill Keese <bill@…>
Resolution: fixed
Status: newclosed

In a3688f79500859e73fb26bcdd91bcda66b793c5b/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Bill Keese <bill@…>

In 0ad614236208ba1130440b18ed649136665ded2f/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by freddefisk

pickerMax: "T23:45:00" - won't this be a problem if the clickableIncrement is less than 15 minutes?

comment:9 Changed 5 years ago by bill

As I wrote in https://github.com/dojo/dijit/pull/65, if you increase the resolution then you need to change pickerMax too. Not sure if there's any easy way to fix that.

The problem with the original patch (using 23:59:59) was that when you didn't specify a min/max, the dropdown was showing 24:00, i.e. it showed midnight twice.

comment:10 Changed 5 years ago by bill

Hmm, seems I can just set it to 23:59:59 and everything works fine. I will do that.

comment:11 Changed 5 years ago by Bill Keese <bill@…>

In 417cdbf4b0181d4f65d36aeefaac36971b457d43/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:11 Changed 5 years ago by Bill Keese <bill@…>

In 0c8a7d936ecf8798aee7dff7a292f931663a43c1/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.