#18200 closed defect (fixed)
[regression] missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker
| Reported by: | kenlau | Owned by: | |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.10.1 |
| Component: | Dijit | Version: | 1.10.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
The property of visibleRange is missing from TimePicker? in 1.10.0. Our code extends TimePicker? and made use of the visibleRange. Because of the missing property which then fails to display the drop down list for time picker.
Change History (12)
comment:1 Changed 8 years ago by
comment:3 Changed 8 years ago by
Have discussed with our architect, we need to get it fixed in 1.10.0 instead of 1.10.1. Thanks.
comment:4 Changed 8 years ago by
| Milestone: | tbd → 1.10.1 |
|---|---|
| Summary: | missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker → [regression] missing property of visibleRange in TimePicker for 1.10.0 which fails to display the drop down list for time picker |
Well, that's impossible without using a time machine to go backwards in time. But I'll mark it for 1.10.1.
comment:5 Changed 8 years ago by
Newer pull request, superceding old one: https://github.com/dojo/dijit/pull/65.
comment:6 Changed 8 years ago by
| Owner: | set to Bill Keese <[email protected]…> |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:8 Changed 8 years ago by
pickerMax: "T23:45:00" - won't this be a problem if the clickableIncrement is less than 15 minutes?
comment:9 Changed 8 years ago by
As I wrote in https://github.com/dojo/dijit/pull/65, if you increase the resolution then you need to change pickerMax too. Not sure if there's any easy way to fix that.
The problem with the original patch (using 23:59:59) was that when you didn't specify a min/max, the dropdown was showing 24:00, i.e. it showed midnight twice.
comment:10 Changed 8 years ago by
Hmm, seems I can just set it to 23:59:59 and everything works fine. I will do that.
The visibleRange feature is addressed in https://github.com/dojo/dijit/pull/60.
It doesn't display at all? As usual, you'll need to attach a test case to show that problem.