Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#18196 closed defect (fixed)

[patch][ccla] Standby endless error loop if target is destroyed in IE10/11

Reported by: Bill Reed Owned by: dylan
Priority: undecided Milestone: 1.7.9
Component: DojoX Widgets Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description

This issue is related to https://bugs.dojotoolkit.org/ticket/14984

If the parent of the target of a dojox.widget.Standby is destroyed via dojo.destroy(), IE10/11 raises an error the next time the Standby's _size() timeout function is called:

SCRIPT16389: Unspecified error.
File: dom-geometry.js, Line: 529, Column: 4

which is where it is calling:

ret = node.getBoundingClientRect();

Calling standby.hide() also fails for the same reason, which leave the widget in an endless loop of calling the Standby._size().

The attached example works correctly in Chrome and Firefox (the standby disappears as soon as the dom node is destroyed), but fails in IE10/11.

I have attached a test case standby_test.html and a proposed patch Stadby.patch While the patch does not address the

SCRIPT16389: Unspecified error.
File: dom-geometry.js, Line: 529, Column: 4

it does fix Standby.hide() allowing the Standby.hide() to clean up and call clearInterval(this._resizeCheck); Stopping the endless loop.

Attachments (2)

standby_test.html (1.3 KB) - added by Bill Reed 5 years ago.
test case
Standby.patch (861 bytes) - added by Bill Reed 5 years ago.
proposed fix

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by Bill Reed

Attachment: standby_test.html added

test case

Changed 5 years ago by Bill Reed

Attachment: Standby.patch added

proposed fix

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Owner: set to dylan
Status: newassigned

@billreed63, do you have a CLA on file, per our contribution guidelines? https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md

comment:2 Changed 4 years ago by dylan

Summary: Standby endless error loop if target is destroyed in IE10/11[patch][cla?] Standby endless error loop if target is destroyed in IE10/11

comment:3 in reply to:  1 Changed 4 years ago by Bill Reed

Replying to dylan:

@billreed63, do you have a CLA on file, per our contribution guidelines? https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md

I don't have an individual CLA, I work for IBM, I believe IBM has a CLA with dojo.

comment:4 Changed 4 years ago by dylan

Milestone: 1.131.11
Summary: [patch][cla?] Standby endless error loop if target is destroyed in IE10/11[patch][ccla] Standby endless error loop if target is destroyed in IE10/11

Indeed, that is fine, thanks billreed63.

comment:5 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In 1f353254905cdde92d3cc874dc9239f2d8f6addd/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 4 years ago by dylans <dylan@…>

In 5356ccf703cfbe6cf0b0e761b8d50c4499a94058/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 4 years ago by dylans <dylan@…>

In cd5b0f840b2cb1a5d6a409b86a9acb8b26e47240/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 4 years ago by dylans <dylan@…>

In 9d217e41e51f9f23af3b1b96bb310d7bcd372e92/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 4 years ago by dylans <dylan@…>

In 21397d3e6c21d4dbfbe92dbb8a8b9775f3790378/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 4 years ago by dylan

Milestone: 1.111.7.9
Note: See TracTickets for help on using tickets.