[patch] [cla] src/widget/html/loader.js contains illegal characthers

[gregory.murray@…]

Starting on Line 704 there are several parameters that contain an ' in the name which is not legal according to ECMA 262-3 secion 7.6

Attached is the fix for this:

Index: loader.js =================================================================== --- loader.js (revision 6403) +++ loader.js (working copy) @@ -701,7 +701,7 @@

}

if(!widgetProto.setContent){

• widgetProto.setContent = function(data, don'tLog){

+ widgetProto.setContent = function(data, dontLog){

this.loader.callOnUnLoad.call(this, true);

if(!data

dojo.html.isNode(data)){

@@ -749,15 +749,15 @@

if(dojo.hostenv.isXDomain && data.requires.length){

dojo.addOnLoad(function(){

asyncParse.call(this, data);

• if(!don'tLog){

+ if(!dontLog){

_loader._log(this, data);

}

}); this opens a thread need abort undo

• don'tLog = true;

+ dontLog = true;

}else{

asyncParse.call(this, data);

}

• }if(!don'tLog){

+ }if(!dontLog){

_loader._log(this, data);

}

};

[gregory.murray@…]

Patch for Issue

[James Burke]

Bill, flipping back to you. This is widget stuff, and not sure how to verify the fix. I can give it a shot if you are busy, but you might have more familiarity with the change given that you last changed the file: ​http://trac.dojotoolkit.org/changeset/6160

[bill]

(In [6430]) Fixes #1819. Patch from Greg Murray (Sun, CCLA on file).

[(none)]

Milestone 0.4.1 deleted