#1819 closed defect (fixed)
[patch] [cla] src/widget/html/loader.js contains illegal characthers
Reported by: | Owned by: | bill | |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | General | Version: | 0.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Starting on Line 704 there are several parameters that contain an ' in the name which is not legal according to ECMA 262-3 secion 7.6
Attached is the fix for this:
Index: loader.js =================================================================== --- loader.js (revision 6403) +++ loader.js (working copy) @@ -701,7 +701,7 @@
}
if(!widgetProto.setContent){
- widgetProto.setContent = function(data, don'tLog){
+ widgetProto.setContent = function(data, dontLog){
this.loader.callOnUnLoad.call(this, true);
if(!data dojo.html.isNode(data)){
@@ -749,15 +749,15 @@
if(dojo.hostenv.isXDomain && data.requires.length){
dojo.addOnLoad(function(){
asyncParse.call(this, data);
- if(!don'tLog){
+ if(!dontLog){
_loader._log(this, data);
}
}); this opens a thread need abort undo
- don'tLog = true;
+ dontLog = true;
}else{
asyncParse.call(this, data);
}
- }if(!don'tLog){
+ }if(!dontLog){
_loader._log(this, data);
}
};
Attachments (1)
Change History (5)
Changed 16 years ago by
Attachment: | issue1918.patch added |
---|
comment:1 Changed 16 years ago by
Milestone: | → 0.4.1 |
---|---|
Owner: | changed from anonymous to James Burke |
Summary: | src/widget/html/loader.js contains illegal characthers → [patch] [cla] src/widget/html/loader.js contains illegal characthers |
comment:2 Changed 16 years ago by
Owner: | changed from James Burke to bill |
---|
Bill, flipping back to you. This is widget stuff, and not sure how to verify the fix. I can give it a shot if you are busy, but you might have more familiarity with the change given that you last changed the file: http://trac.dojotoolkit.org/changeset/6160
comment:3 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Patch for Issue