CalendarLite: add firstDayOfWeek option like CalendarBase

[szerfas]

To match Calendar's firstDayOfWeek CalendarLite? should be updated to have the same attribute/capability. Right now the only behavior on CalendarLite? is to go with the locale behavior.

Use Cases: -There are situations where we are targeting a timezone outside of the current timezone. -There are business cases where we would like the weekdays kept together and the weekend days kept together, i.e. start the week on a Monday like we currently do on Calendar.

[bill]

I guess you are talking about diit/CalendarLite vs. dojox/calendar/CalendarBase? If so, the component needs to be changed.

[szerfas]

Yes, digit/CalendarLite. Inspecting the code it looks like the only way it will function is getting the first day of the week for the locale. Hoping it could be modified to be like CalendarBase? in that -1 is by locale and the positive numbers indicate the day of the week.

[bill]

OK... makes sense. If you want to supply a pull request for that, including an automated test case (and sign the CLA) I'll take a look.

[szerfas]

Hi Bill. Are there instructions for how to create the pull request and automated test? This is only the second issue I have submitted on this forum. Thinking the automated test would pretty much involve instantiate CalendarLite? with attribute of firstDayOfWeek as both -1 and at least some offset. Thanks!

[szerfas]

I found the documentation I was looking for. Thinking for the test I just need to modify CalendarLite?.html with setting firstDayOfWeek to -1 or 1. This is really a visual change so there is no value to verify. I will create and put in a pull request.

[bill]

@szerfas - Thanks for the test, but what I really meant was to supply a pulll request that:

1. implements the enhancement
2. includes an automated test that the enhancement is working

This is really a visual change so there is no value to verify.

By that logic dijit would have no automated tests whatsoever. It's true that we don't have tests for CSS styling, but we do have tests for structural things like this.

[szerfas]

Thanks for the reply Bill. Did not realize you were entrusting me to make the code change, I can do that and create a new pull request. Sorry on the test, I looked at what there was for CalendarLite? so far and it as doing nothing more then setting and verifying the value it was getting, very basic. I will dig deeper into some other tests that I could model after to verify the structure.

[Bill Keese <[email protected]…>]

In 511db8ac99afc1a61da3b3a2314d93c9dc029ec8/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 16b69e179db07278ac22568fda455f6844972e1c/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 451eee0394f28709ed685a955813d00992d13316/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?