Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#18172 closed enhancement (fixed)

CalendarLite: add firstDayOfWeek option like CalendarBase

Reported by: szerfas Owned by: szerfas
Priority: undecided Milestone: 1.11
Component: Dijit Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description

To match Calendar's firstDayOfWeek CalendarLite? should be updated to have the same attribute/capability. Right now the only behavior on CalendarLite? is to go with the locale behavior.

Use Cases: -There are situations where we are targeting a timezone outside of the current timezone. -There are business cases where we would like the weekdays kept together and the weekend days kept together, i.e. start the week on a Monday like we currently do on Calendar.

Change History (11)

comment:1 Changed 5 years ago by bill

Owner: set to szerfas
Status: newpending

I guess you are talking about diit/CalendarLite vs. dojox/calendar/CalendarBase? If so, the component needs to be changed.

comment:2 Changed 5 years ago by szerfas

Status: pendingnew

Yes, digit/CalendarLite. Inspecting the code it looks like the only way it will function is getting the first day of the week for the locale. Hoping it could be modified to be like CalendarBase? in that -1 is by locale and the positive numbers indicate the day of the week.

comment:3 Changed 5 years ago by bill

Component: DojoxDijit
Summary: CalendarLite needs firstDayOfWeek like CalendarBaseCalendarLite: add firstDayOfWeek option like CalendarBase

OK... makes sense. If you want to supply a pull request for that, including an automated test case (and sign the CLA) I'll take a look.

comment:4 Changed 5 years ago by szerfas

Hi Bill. Are there instructions for how to create the pull request and automated test? This is only the second issue I have submitted on this forum. Thinking the automated test would pretty much involve instantiate CalendarLite? with attribute of firstDayOfWeek as both -1 and at least some offset. Thanks!

comment:5 Changed 5 years ago by szerfas

I found the documentation I was looking for. Thinking for the test I just need to modify CalendarLite?.html with setting firstDayOfWeek to -1 or 1. This is really a visual change so there is no value to verify. I will create and put in a pull request.

comment:6 Changed 5 years ago by bill

@szerfas - Thanks for the test, but what I really meant was to supply a pulll request that:

  1. implements the enhancement
  2. includes an automated test that the enhancement is working

This is really a visual change so there is no value to verify.

By that logic dijit would have no automated tests whatsoever. It's true that we don't have tests for CSS styling, but we do have tests for structural things like this.

comment:7 Changed 5 years ago by szerfas

Thanks for the reply Bill. Did not realize you were entrusting me to make the code change, I can do that and create a new pull request. Sorry on the test, I looked at what there was for CalendarLite? so far and it as doing nothing more then setting and verifying the value it was getting, very basic. I will dig deeper into some other tests that I could model after to verify the structure.

comment:8 Changed 5 years ago by bill

Milestone: tbd1.11

comment:9 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: newclosed

In 511db8ac99afc1a61da3b3a2314d93c9dc029ec8/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by Bill Keese <bill@…>

In 16b69e179db07278ac22568fda455f6844972e1c/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:11 Changed 4 years ago by Bill Keese <bill@…>

In 451eee0394f28709ed685a955813d00992d13316/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.