Opened 5 years ago

Closed 4 years ago

#18163 closed defect (patchwelcome)

Filtering Select doesn't cater for a function as a query correctly

Reported by: zevvy2@… Owned by:
Priority: undecided Milestone: 1.13
Component: Dijit - Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

dijit/form/FilteringSelect does a check for query[this.searchAttr] on line 92 in the _openResultList function. This conditional is dependent on the query being an object. This is not a requirement for FilteringSelect? and so when a function is provided as a the query, this conditional fails and the dropdown fails to open.

Change History (4)

comment:1 Changed 5 years ago by bill

I see your point although as the comment says, that code is currently needed (or at least nice) to avoid posting results from old queries that arrived out of order. Probably the old queries should be canceled when new queries are triggered. Or maybe they are already getting canceled and that's just vestigal code.

Before changing this I would need a test case with a function as a query. I guess it's possible to have a function as a query for Memory store?

comment:2 Changed 5 years ago by vtsuper

comment:3 Changed 5 years ago by bill

Component: DijitDijit - Form

Sorry, no updates, but note as I said 7 months ago that before addressing this I would need a test case with a function as a query.

comment:4 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in more than a year, I'm closing this as patchwelcome. Please let us know if you would like to get involved in helping make this change to Dojo!

Note: See TracTickets for help on using tickets.