Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18138 closed defect (fixed)

dijit/layout/LayoutContainer layoutPriority unexpected results

Reported by: Wouter Hager Owned by: Bill Keese <bill@…>
Priority: undecided Milestone: tbd
Component: General Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description

When setting the layoutPriority of the top region to 1, the layout design changed from headline to sidebar, while I expected the top priority to become highest. I think that layoutPriority should always weigh more than the design or the DOM order.

Change History (5)

comment:1 Changed 5 years ago by Wouter Hager

So I understand that the priority means closer to center, and consequently less important to layout, but that seems counter-intuitive. Perhaps the priority should be inverted and higher priority should mean further from center and more important to layout.

comment:2 Changed 5 years ago by Wouter Hager

The docs mention this, so just close this ticket:

However, the layoutPriority setting for child panes overrides the design attribute on the LayoutContainer?. In other words, if the top and bottom sections have a lower layoutPriority then the left and right panes then the top and bottom panes will extend the entire width of the box.

Perhaps it could be emphasized that higher priority means less important to design.

comment:3 Changed 5 years ago by Bill Keese <bill@…>

Owner: set to Bill Keese <bill@…>
Resolution: fixed
Status: newclosed

In 90fdd44e578ddf9076287a70e43f0ce754e4e32a/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 5 years ago by Bill Keese <bill@…>

Owner: set to Bill Keese <bill@…>
Resolution: fixed
Status: newclosed

In 8cd4c9dc2cf58f7a47f62baac78b322d75cdd8b7/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by bill

However, the layoutPriority setting for child panes overrides the design attribute on the LayoutContainer?. In other words, if the top and bottom sections have a lower layoutPriority then the left and right panes then the top and bottom panes will extend the entire width of the box.

I updated the doc to make this clearer.

Perhaps it could be emphasized that higher priority means less important to design.

Well, "less important to design" doesn't have any concrete meaning to me. The documentation already says:

layoutPriority flag on the children determines which child is closer to the edge (low layoutPriority) and which child is closer to the center (high layoutPriority)

Perhaps it's counterintuitive, but I can't change it now because of backwards compatibility.

Note: See TracTickets for help on using tickets.