Opened 7 years ago
Closed 7 years ago
#18131 closed defect (fixed)
Deferred instrumentation logs error when downstream promise handles error
Reported by: | Kris Zyp | Owned by: | |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.8 |
Component: | General | Version: | 1.10.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If you define a downstream error handler, errors/rejections can still be reported as unhandled. For example:
var deferred = new Deferred(); // provide an error handler downstream deferred.then(function(){}).then(null, function(){}); // throw error, it is handled, but shows up as unhandled. deferred.reject(new Error());
Change History (3)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
Milestone: | tbd → 1.11 |
---|
As far as testing, I don't think instrumentation has any tests, and this is just a tweak in when we report errors.
comment:3 Changed 7 years ago by
Milestone: | 1.11 → 1.8.8 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
master ebaf3eddc8d8ceb80da078f21269d0cad0235b6f 1.10 e16adb441dea583492415dc79f240a14a3485ea0 1.9 d0820cab82a94db1c0b81cfaa100c1a8154302e8 1.8 df0fff25015e5389de35f0d2a8929cdbd4c06f77
Note: See
TracTickets for help on using
tickets.
In ebaf3eddc8d8ceb80da078f21269d0cad0235b6f/dojo: