Opened 7 years ago
Closed 5 years ago
#18127 closed defect (patchwelcome)
dojox/dtl/_Templated parsing of child widgets
Reported by: | fran.pregernik | Owned by: | |
---|---|---|---|
Priority: | undecided | Milestone: | 1.13 |
Component: | DojoX DTL | Version: | 1.10.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
There is a possible bug in the way that the child widgets are parsed.
I have a template with a ContentPane? and some child widgets inside of a table (inside of the contentpane).
There is an option to to tell the parser to parse them and the _WidgetsInTemplateMixin is using it (option: "templated") but the DTL _Templated is not using it.
See the different options passed to the parser:
https://github.com/dojo/dojox/blob/master/dtl/_Templated.js#L74 https://github.com/dojo/dijit/blob/master/_WidgetsInTemplateMixin.js#L45
DTL Templated:
var cw = (this._startupWidgets = Parser.parse(node, { noStart: !this._earlyTemplatedStartup, inherited: {dir: this.dir, lang: this.lang} }));
_WidgetsInTemplateMixin:
parser.parse(node, { noStart: !this._earlyTemplatedStartup, template: true, inherited: {dir: this.dir, lang: this.lang, textDir: this.textDir}, propsThis: this, // so data-dojo-props of widgets in the template can reference "this" to refer to me contextRequire: this.contextRequire, scope: "dojo" // even in multi-version mode templates use dojoType/data-dojo-type })
The emphasis here is on the "templated" option but these parser invocations should probably be updated in the DTL version.
Change History (1)
comment:1 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given the lack of attention that dojox/dtl has received, I'm closing this ticket as patchwelcome. If you would like to work on a fix, please create a pull request and reopen the ticket.