[regression] JsonRest _getTarget in 1.10.0 breaks targets like "/path/to/target?idProperty="

[psbucky]

A simple fix might be to change:

if(target.charAt(target.length-1) == '/'){

to

if((target.charAt(target.length-1) == '/') || (target.charAt(target.length-1) == '=')){

A simple workaround to code that was working in 1.9.3 might be to add

_getTarget:function(id){ return this.target+id; }

to the initializer

[psbucky]

I guess my description wasn't good.

With a PHP backend, I found that my targets like

/path/to/target?idProperty=

...were generating requests with a '/' prepended to the idProperty. Like if the id is 5, I was getting requests like

/path/to/target?idProperty=/5

...instead of what I was used to with dojo 1.9.3:

/path/to/target?idProperty=5

It would seem that _getTarget in 1.10.0 is the culprit in generating the unwanted slashes. I'm requesting that _getTarget be changed to test for terminal '=' signs as well as terminal '/' characters.

In the meantime, for others who may have migration issues, I'm offering the workaround to simply override getTarget in the object initializer to quickly get JsonRest? working in 1.10.0 like it used to in 1.9.3.

[bill]

So a regression from 7a0ebb9 or 37233ca?

[Colin Snover]

1.10.1 has been released, retargeting all open tickets to next milestone.

[Colin Snover]

1.10.2 has been released; moving to next milestone.

[tsemachh]

+1 for this one , we are failing on this one as well

[dylan]

PR added at ​https://github.com/dojo/dojo/pull/177

[dylan]

Fixed in master ( ​https://github.com/dojo/dojo/commit/606f888b577a527da4272c6f8cf4887395b81078 ) and 1.10 ( ​https://github.com/dojo/dojo/commit/c63fe83ed671d9a6c8e69eecbcc6868d39925af9 )