Opened 6 years ago
Closed 4 years ago
#18121 closed enhancement (fixed)
Add functional bower.json to dojo, dojox, dijit, util
| Reported by: | nickmaynard | Owned by: | dylan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.11 |
| Component: | General | Version: | 1.10.0 |
| Keywords: | Cc: | cjolif | |
| Blocked By: | Blocking: |
Description
Bower does not support package.json. Though discussed here https://github.com/bower/bower/pull/62 in detail, all pull requests were eventually declined - see https://github.com/bower/bower/pull/884, etc.
Bower only supports bower.json.
Consequently, we should add bower.json specifications to dojo, dojox, dijit etc. Importantly, the issue of submodules (.gitmodules) will need to be addressed. A solution similar to that used by gitmodules-bower might be helpful for this.
Change History (24)
comment:1 Changed 6 years ago by
| Cc: | cjolif added |
|---|
comment:3 Changed 6 years ago by
It's incredibly stupid that every project on earth should have to maintain multiple metadata files because people cannot agree on a common format. That said, I understand the frustration and I'll accept that we need to do this, though I hope this type of thinking will end soon, as I do not want to be in a situation of supporting dozens of configuration files forever. It's busy work rather than something fruitful.
comment:4 Changed 5 years ago by
| Milestone: | tbd → 1.11 |
|---|---|
| Priority: | undecided → blocker |
comment:5 Changed 5 years ago by
| Priority: | blocker → high |
|---|
comment:6 Changed 5 years ago by
| Owner: | set to dylan |
|---|---|
| Status: | new → assigned |
comment:7 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:8 Changed 5 years ago by
comment:11 Changed 5 years ago by
Themes: https://github.com/dojo/themes/commit/68ef7a1a07f8bed4ac91d39106bf1c7652bef1e0
Ok, bower.json has been added to dojo, dijit, dojox, util, and themes. If improvements are needed, please open pull requests against the relevant repo and reference this this ticket number. Thanks.
comment:19 Changed 4 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:24 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Additionally, see Bower changelog for v0.5.0 (2012-11-09) where package.json support was removed. https://github.com/bower/bower/blob/master/CHANGELOG.md#050---2012-11-19