Opened 6 years ago

Closed 5 years ago

#18121 closed enhancement (fixed)

Add functional bower.json to dojo, dojox, dijit, util

Reported by: nickmaynard Owned by: dylan
Priority: high Milestone: 1.11
Component: General Version: 1.10.0
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

Bower does not support package.json. Though discussed here ​https://github.com/bower/bower/pull/62 in detail, all pull requests were eventually declined - see ​https://github.com/bower/bower/pull/884, etc.

Bower only supports bower.json.

Consequently, we should add bower.json specifications to dojo, dojox, dijit etc. Importantly, the issue of submodules (.gitmodules) will need to be addressed. A solution similar to that used by ​gitmodules-bower might be helpful for this.

Change History (24)

comment:1 Changed 6 years ago by cjolif

Cc: cjolif added

comment:2 Changed 6 years ago by nickmaynard

Additionally, see Bower changelog for v0.5.0 (2012-11-09) where package.json support was removed. ​https://github.com/bower/bower/blob/master/CHANGELOG.md#050---2012-11-19

Last edited 6 years ago by nickmaynard (previous) (diff)

comment:3 Changed 6 years ago by dylan

It's incredibly stupid that every project on earth should have to maintain multiple metadata files because people cannot agree on a common format. That said, I understand the frustration and I'll accept that we need to do this, though I hope this type of thinking will end soon, as I do not want to be in a situation of supporting dozens of configuration files forever. It's busy work rather than something fruitful.

comment:4 Changed 6 years ago by dylan

Milestone: tbd → 1.11
Priority: undecided → blocker

comment:5 Changed 5 years ago by dylan

Priority: blocker → high

comment:6 Changed 5 years ago by dylan

Owner: set to dylan
Status: new → assigned

Dojo 1.11: ​https://github.com/dojo/dojo/commit/0fcc8283beb391206f7c8d50b0b384c412684119

comment:7 Changed 5 years ago by dylans <[email protected]…>

Resolution: → fixed
Status: assigned → closed

In db0e3649de2ce15fb7578ee6badf925a5033e408/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:9 Changed 5 years ago by dylans <[email protected]…>

In a1ee3f3f26bfa8b839ebf366ba4eee73da46e0c3/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:10 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In 434e36e9c39f590f0f2ac71cea64670ca8d7a857/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:11 Changed 5 years ago by dylan

Themes: ​https://github.com/dojo/themes/commit/68ef7a1a07f8bed4ac91d39106bf1c7652bef1e0

Ok, bower.json has been added to dojo, dijit, dojox, util, and themes. If improvements are needed, please open pull requests against the relevant repo and reference this this ticket number. Thanks.

comment:12 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In 3da1e94/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:13 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In d2ccca3/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:14 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In 5ccb673/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:15 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In 9e48f8e/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:16 Changed 5 years ago by dylans <[email protected]…>

In 41b71ab/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:17 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In d40757e/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:18 Changed 5 years ago by dylans <[email protected]…>

In c8398a7/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:19 Changed 5 years ago by dylan

Resolution: fixed
Status: closed → reopened

comment:20 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In f3a71b4/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:21 Changed 5 years ago by dylans <[email protected]…>

In 5146091d/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:22 Changed 5 years ago by dylans <[email protected]…>

In 946a1fb/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:23 Changed 5 years ago by Dylan Schiemann <[email protected]…>

In eb49547/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:24 Changed 5 years ago by dylan

Resolution: → fixed
Status: reopened → closed
Note: See TracTickets for help on using tickets.