Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18102 closed defect (fixed)

Build fails if mapped modules are used as dependencies

Reported by: Colin Snover Owned by: Colin Snover
Priority: high Milestone: 1.9.4
Component: BuildSystem Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

When a user uses dojoConfig.map, they expect to be able to build code that uses these maps. Currently, the build system does not process any map configuration, which means end-users that attempt to use map to alias module segments will not be able to build their code.

For example, given the directory structure:

src/
  app/
    foo.js
  dojo110/
    query.js
  dojo19/
    query.js

and the map configuration:

dojoConfig.map = {
  '*': {
    'dojo': 'dojo110'
  }
};

and a module app/foo:

define([ 'dojo/query' ], function (query) {});

This code will work in development, correctly translating the module identifier dojo/query to dojo110/query, but will fail to build because there is no src/dojo/query.js.

Patch forthcoming.

Change History (6)

comment:1 Changed 5 years ago by Colin Snover

Status: newassigned

comment:3 Changed 5 years ago by Colin Snover

1.9.4 has been released, retargeting all open tickets to next milestone.

comment:4 Changed 5 years ago by Colin Snover

Milestone: 1.9.41.9.5

comment:5 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: assignedclosed

In 00884aac64c6a305b9b0236be57833438be7f9ed/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Colin Snover

Milestone: 1.9.51.9.4

Webhooks issues again…

master 6ad2af6c7cc33e061feb0364274e27bacb7e880e 1.10 00884aac64c6a305b9b0236be57833438be7f9ed 1.9 16832475f481363e30dbfa422d5efdf75dcb1f15

Due to I keep forgetting about 1.10 being a thing, this patch didn’t make it into 1.10.1 but will be in 1.10.2. It is in 1.9.4 and master.

Note: See TracTickets for help on using tickets.