Opened 5 years ago

Closed 4 years ago

#18100 closed defect (fixed)

dojo can not be loaded in firefox 30 webworker

Reported by: liucougar Owned by: dylan
Priority: high Milestone: 1.10.5
Component: Loader Version: 1.10.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by liucougar)

the problem seems to come from line 171 in file dojo/_base/kernel.js

console[tcn]._fake = true;

it seems console object is immutable in webworker since firefox 30

Change History (14)

comment:1 Changed 5 years ago by dylan

Milestone: tbd1.10.1
Priority: undecidedblocker

comment:2 Changed 5 years ago by dylan

I don't see Dojo not being loadable at all in Firefox... do you mean it cannot be loaded when using WebWorkers??

comment:3 Changed 5 years ago by liucougar

Description: modified (diff)
Summary: dojo can not be loaded in firefox 30dojo can not be loaded in firefox 30 webworker

comment:4 Changed 5 years ago by liucougar

yes, it's not loading in web worker (just updated title to make it clear)

(also updated line number in the description)

comment:5 Changed 5 years ago by liucougar

Description: modified (diff)

comment:6 Changed 5 years ago by ben hockey

Priority: blockerhigh

i'm not sure this should have a priority of "blocker" since now it's been clarified that it's only in WebWorkers? and it looks like you can work around that section of code by turning off the dojo-guarantee-console has feature. i'm reducing the priority just as a matter of housekeeping.

Last edited 5 years ago by ben hockey (previous) (diff)

comment:7 Changed 5 years ago by liucougar

actually, the workaround by turning off 'dojo-guarantee-console' is not possible: right before that if block, dojo-guarantee-console is set to 1 unconditionally, so I don't see how someone could overwrite that

Last edited 5 years ago by liucougar (previous) (diff)

comment:8 Changed 5 years ago by ben hockey

has.add only sets the value if there's no existing value. the cache for has can be primed by using dojoConfig.hasCache which will cause that has.add call to be ineffective if you already provided a value - see http://jsbin.com/gozofoxe/1/edit

comment:9 Changed 5 years ago by Colin Snover

Milestone: 1.10.11.10.2

1.10.1 has been released, retargeting all open tickets to next milestone.

comment:10 Changed 5 years ago by Colin Snover

Milestone: 1.10.21.10.3

1.10.2 has been released; moving to next milestone.

comment:11 Changed 4 years ago by dylan

Milestone: 1.10.31.11
Priority: highblocker

comment:12 Changed 4 years ago by dylan

Owner: set to dylan
Status: newassigned

comment:13 Changed 4 years ago by dylan

Priority: blockerhigh

comment:14 Changed 4 years ago by dylan

Milestone: 1.111.10.5
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.