Possible bug in dojo/request/xhr

[Jared Jurkiewicz]

I think there is a logic error in dojo/request/xhr. Specifically, it calls the handlers (json, xml, etc), before it checks the actual status of the xhr. So if you say get a 504, and junk back, handleAs JSON fails, but the error you get is a parse error instead of knowing it parse errored BECAUSE the status was non-success. So, shouldn't this be:

if(util.checkStatus(_xhr.status)){

if(error){

this.reject(error);

}else{

this.resolve(response);

}

}else{

error = new RequestError?('Unable to load ' + response.url + ' status: ' + _xhr.status, response); this.reject(error);

}

Instead?

[bill]

AFAICT this isn't a regression, so it shouldn't block the 1.10 release.

[Jared Jurkiewicz]

Pull request to fix error reporting order: ​https://github.com/dojo/dojo/pull/92

[ben hockey]

isn't it possible that people rely on the current behavior to parse a json response in the case of something like authorization failing (status 401)? won't this change regress what they have come to rely on?

[ben hockey]

as discussed on github, the desired result can be achieved using the response promise