Opened 5 years ago

Last modified 3 years ago

#18084 assigned defect

[patch][cla] _maskUtils does not properly create SVG mask when specifying left and right borders for the mask

Reported by: Sebastien Brunot Owned by: Sebastien Brunot
Priority: undecided Milestone: 1.15
Component: DojoX Mobile Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

Reproduced with Firefox 24.5.0 ESR on Mac OS X 10.9.

When displaying the included test page test_maskUtils.html on a non webkit browser that supports SVG, the mask is not correct.

See the attached screenshots: safari.tiff shows how the mask is correctly displayed in Safari, firefox.tiff shows how the mask is wrongly displayed in firefox.

The issue can be fixed by updating _maskUtils.js createRoundMask function as following:

// Fix for this ticket
if (l > 0) {
    d += " M0,0 h" + l + " v" + th + " h" + (-l) + " z";
}
if (r > 0) {
    d += " M" + (l + w) + ",0 h" + (r) + " v" + th + " h" + (-r) + " z";
}
// End of fix for this ticket
if (t > 0) {
    d += " M0,0 h" + tw + " v" + t + " h" + (-tw) + " z";
}
if (b > 0) {
    d += " M0," + (t + h) + " h" + tw + " v" + b + " h" + (-tw) + " z";
}

Attachments (3)

test_maskUtils.html (1.0 KB) - added by Sebastien Brunot 5 years ago.
safari.tiff (14.2 KB) - added by Sebastien Brunot 5 years ago.
firefox.tiff (11.4 KB) - added by Sebastien Brunot 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Sebastien Brunot

Attachment: test_maskUtils.html added

Changed 5 years ago by Sebastien Brunot

Attachment: safari.tiff added

Changed 5 years ago by Sebastien Brunot

Attachment: firefox.tiff added

comment:1 Changed 5 years ago by Sebastien Brunot

Owner: set to Sebastien Brunot
Status: newassigned

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12
Summary: _maskUtils does not properly create SVG mask when specifying left and right borders for the mask[patch][cla] _maskUtils does not properly create SVG mask when specifying left and right borders for the mask

Care to create a pull request sbrunot? Otherwise I'll handle it for 1.12.

comment:3 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.