Opened 7 years ago
Last modified 5 years ago
#18084 assigned defect
[patch][cla] _maskUtils does not properly create SVG mask when specifying left and right borders for the mask
Reported by: | Sebastien Brunot | Owned by: | Sebastien Brunot |
---|---|---|---|
Priority: | undecided | Milestone: | 1.15 |
Component: | DojoX Mobile | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Reproduced with Firefox 24.5.0 ESR on Mac OS X 10.9.
When displaying the included test page test_maskUtils.html on a non webkit browser that supports SVG, the mask is not correct.
See the attached screenshots: safari.tiff shows how the mask is correctly displayed in Safari, firefox.tiff shows how the mask is wrongly displayed in firefox.
The issue can be fixed by updating _maskUtils.js createRoundMask function as following:
// Fix for this ticket if (l > 0) { d += " M0,0 h" + l + " v" + th + " h" + (-l) + " z"; } if (r > 0) { d += " M" + (l + w) + ",0 h" + (r) + " v" + th + " h" + (-r) + " z"; } // End of fix for this ticket if (t > 0) { d += " M0,0 h" + tw + " v" + t + " h" + (-tw) + " z"; } if (b > 0) { d += " M0," + (t + h) + " h" + tw + " v" + b + " h" + (-tw) + " z"; }
Attachments (3)
Change History (6)
Changed 7 years ago by
Attachment: | test_maskUtils.html added |
---|
Changed 7 years ago by
Attachment: | safari.tiff added |
---|
Changed 7 years ago by
Attachment: | firefox.tiff added |
---|
comment:1 Changed 7 years ago by
Owner: | set to Sebastien Brunot |
---|---|
Status: | new → assigned |
comment:2 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|---|
Summary: | _maskUtils does not properly create SVG mask when specifying left and right borders for the mask → [patch][cla] _maskUtils does not properly create SVG mask when specifying left and right borders for the mask |
comment:3 Changed 5 years ago by
Milestone: | 1.13 → 1.15 |
---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
Note: See
TracTickets for help on using
tickets.
Care to create a pull request sbrunot? Otherwise I'll handle it for 1.12.