Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18082 closed enhancement (fixed)

[PATCH][CLA] dojox/gfx/svg allows setting of negative width/height

Reported by: Jared Jurkiewicz Owned by: edurocher <edurocher0@…>
Priority: undecided Milestone: 1.11
Component: DojoX GFX Version: 1.10.0-beta1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Jared Jurkiewicz)

This is a minor issue, but it can be annoying in Google Chrome. If a negative width or height is applied to a shape, Google Chrome emits an annoying message in its debugger. It does not, however, give you a stack trace to figure out how the negative width came in. So, you cannot actually go fix the culprit. Nor does it break anything as it seems Chrome then just ignores the value and treats it as 0 anyway.

So, it would be handy to silence that useless message so actual debug able messages aren't lost in the clutter. Patch/pull request forthcoming to 'resolve' it by just ensuring that any negative dimension value is normalized to 0 before being set on the dom.

The cases where I have seen this happen are commonly with animated charts and resize events, and the timing thereof during them.

Change History (6)

comment:1 Changed 5 years ago by Jared Jurkiewicz

Description: modified (diff)

comment:2 Changed 5 years ago by Jared Jurkiewicz

Description: modified (diff)

comment:3 Changed 5 years ago by Jared Jurkiewicz

Description: modified (diff)

comment:4 Changed 5 years ago by Jared Jurkiewicz

comment:5 Changed 5 years ago by edurocher <edurocher0@…>

Owner: set to edurocher <edurocher0@…>
Resolution: fixed
Status: newclosed

In 5bd9ae85f30181fe6dbb8eb750d4f5ebfd3d5d0a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Eric Durocher

Milestone: tbd1.11
Note: See TracTickets for help on using tickets.