Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18081 closed defect (fixed)

[PATCH][CLA] dojox/gfx/_base.js can mess up rendering on IE due to font metric checking.

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz <jared.jurkiewicz@…>
Priority: undecided Milestone: 1.8.7
Component: DojoX GFX Version: 1.10.0-beta1
Keywords: Cc:
Blocked By: Blocking:

Description

This is related to ticket 18080. There is an issue in the dojox/gfx/_base.js file where it ends up clobbering the font size on <html>. This causes significant CSS/rendering issues if you are specifying a font size on those elements. The code should set it, get the measurements, then restore the old font size. It should not leave its over-ride. Patch forthcoming.

Change History (8)

comment:1 Changed 5 years ago by Jared Jurkiewicz

Pull request for this: ​https://github.com/dojo/dojox/pull/116

comment:2 Changed 5 years ago by Jared Jurkiewicz

Summary: [CLA] dojox/gfx/_base.js can mess up rendering on IE due to font metric checking. → [PATCH][CLA] dojox/gfx/_base.js can mess up rendering on IE due to font metric checking.

comment:3 Changed 5 years ago by Jared Jurkiewicz <jared.jurkiewicz@…>

Owner: set to Jared Jurkiewicz <jared.jurkiewicz@…>
Resolution: → fixed
Status: new → closed

In 7a323156a1996e2e1c8a15f103f38422c1b449fe/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:4 Changed 5 years ago by Jared Jurkiewicz <jared.jurkiewicz@…>

In 56f4693e6366507a11a485c53b8d3e86bf92b478/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:5 Changed 5 years ago by Jared Jurkiewicz <jared.jurkiewicz@…>

In f23fe37c9d30019ed1c258624f4905663ba956c9/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:6 Changed 5 years ago by Jared Jurkiewicz <jared.jurkiewicz@…>

In 20aa320c37a28c2b3cc710439e0c313201ef88ba/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:7 Changed 5 years ago by Jared Jurkiewicz

Fixed and backported to 1.10, 1.9, 1.8

comment:8 Changed 5 years ago by Jared Jurkiewicz

Milestone: tbd → 1.8.7
Note: See TracTickets for help on using tickets.