[patch][cla][pr][verify test] Have Observable work with relational data

[Wouter Hager]

Since recent changes in dijit/tree/ObjectStore, working with many-to-many relationships in a tree has been most successful. There remains only one problem: when removing only the relationship to one node, its duplicates are removed in every branch. This is because in Observable expects a 1-to-many relationship, and there's no check for the origin of removed items.

Short explanation: in my model, nodes can be duplicated in the tree by adding intermediary relationships (many-to-many). These can be removed by passing a custom relationshipOnly option to store.remove(). I think the tree store should be agnostic of relationship management, so I see no other way to do this.

The problem is on line 79:

if(queryExecutor || !changed){// if it was changed and we don't have a queryExecutor, we shouldn't remove it because updated objects would be eliminated
resultsArray.splice(i, 1);

This will simply remove every object passed through store.remove() from the resultsArray by its identity.

I think the way to solve this is to requery the data before removing the object, in the same manner as is done for changing objects. I don't have a proposal where to fit this in, so I will leave that open.

[Wouter Hager]

I created a pull request that will provide me with a minimal mechanism to deal with this issue: ​https://github.com/dojo/dojo/pull/111

[dylan]

Fixed in ​https://github.com/dojo/dojo/commit/c7b154cae5cd209d1b4723404033fe97f7f5e5ec, backported to 1.10 in ​https://github.com/dojo/dojo/commit/97f06083b429522f8d379efb6c6b22108348717e