Opened 5 years ago

Closed 4 years ago

#18061 closed enhancement (fixed)

[PATCH][CLA] Make theme color cycles consistent across chart plots.

Reported by: Jared Jurkiewicz Owned by:
Priority: undecided Milestone: 1.11
Component: Charting Version: 1.10.0-beta1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently several plots draw colors from the theme file in reverse order. This is seen with area and bar charts, and any derivative. But, Pie plot draws them forward. From ease of use of theme development and consistent display when multiple charts of multiple types are in a page it should use the same direction.

It turns out that now with the current way the plots draw that line, area, bar, etc, (including stacked) will draw fine with the iteration loop reversed. (This used to not be the case but with improvements in Dojo it now works). So a pull request is coming that reverses the sequence so that all of the plots will render in forward order (which makes building and understanding theme application simpler).

Change History (7)

comment:1 Changed 5 years ago by Jared Jurkiewicz

Note the reversal to be forward-rendering doesn't affect stacked charts either (surprisingly). In the past it would, but in the updated plots that exist in modern dojo it works fine.

comment:2 Changed 5 years ago by Jared Jurkiewicz

Type: defectenhancement

comment:4 Changed 5 years ago by cjolif

The concern I have here is compatibility. Obviously what you propose would be more logical but any app counting on the counter intuitive result will suddenly "break".

This is related to https://bugs.dojotoolkit.org/ticket/15359 as well.

comment:5 Changed 5 years ago by Jared Jurkiewicz

Simple solution to that concern would be to make it switchable, with the default being current behavior. That way apps that want a logical flow from the theme can turn it on, with the target of in Dojo 2.0 to draw them logically in the first place.

comment:6 Changed 5 years ago by Jared Jurkiewicz

Summary: Make theme color cycles consistent across chart plots.[PATCH][CLA] Make theme color cycles consistent across chart plots.

comment:7 Changed 4 years ago by Jared Jurkiewicz

Milestone: tbd1.11
Resolution: fixed
Status: newclosed

This has been merged in to make the plots render consistently with the theme (forward direction). Merged by request of Dylan.

Note: See TracTickets for help on using tickets.