Opened 6 years ago

Closed 5 years ago

#18060 closed defect (fixed)

[PATCH][CLA] Allow null stroke and non-null outline in chart plots

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: tbd
Component: Charting Version: 1.10.0-beta1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently if you have a null stroke but a non-null outline, the chart plots will fail with a null reference (null.width). This causes rendering to fail. There are theme use cases where you turn off the stroke, but still apply an outline. This has come up in styling use cases where I work. Setting stroke width to 0 does not work, as if you draw in SVG a stroke of width 0, Chrome fails. Specifically, Chrome will stop evening on the dom correctly; it does not like width 0 on paths. So, null needs to be supported. This is a trivial tweak to the outline apply code.

Pull request forthcoming.

Change History (7)

comment:2 Changed 5 years ago by Jared Jurkiewicz

Summary: Allow null stroke and non-null outline in chart plots[PATCH][CLA] Allow null stroke and non-null outline in chart plots

comment:3 Changed 5 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

comment:4 Changed 5 years ago by Jared Jurkiewicz

Priority: undecidedhigh

comment:5 Changed 5 years ago by Jared Jurkiewicz

Resolution: fixed
Status: closedreopened

comment:6 Changed 5 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz
Status: reopenedassigned

comment:7 Changed 5 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.