Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1804 closed defect (fixed)

event.stopEvent method causes errors in IE6 for onselectstart event

Reported by: dojo-contributors@… Owned by: alex
Priority: high Milestone:
Component: Events Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description

I have noticed an obscure IE6 bug (Win XP SP2) in the event.stopEvent() method. This method just chains together the Microsoft equivalents of preventDefault() and stopPropagation().

But for the event "onselectstart", which is an IE-only event that fires when the user begins to select text with the cursor, using stopEvent on this type of event throws errors from within the "run" method extended onto dojo.event.MethodJoinPoint?.

I have no idea why IE chooses to exhibit this problem for this type of event. But the fix is simple:

On rev. 6380 of event/browser.js, at line 496:

change:

if(window.event){

evt.returnValue = false; evt.cancelBubble = true;

to:

if(window.event){

evt.cancelBubble = true; evt.returnValue = false;

Change History (3)

comment:1 Changed 13 years ago by Adam Peller

Resolution: fixed
Status: newclosed

Fixed in [6386]

comment:2 Changed 13 years ago by Adam Peller

Milestone: 0.4.1

comment:3 Changed 13 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.