#18025 closed defect (fixed)
Builder mangles window.console causing an error in the optimizer
Reported by: | Ed Hager | Owned by: | Ed Hager |
---|---|---|---|
Priority: | high | Milestone: | 1.10 |
Component: | BuildSystem | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If a module uses window.console
rather than just console
, the builder causes the closure compiler to fail.
window.console.info("foo");
Is replaced with:
window.0 && console.info("foo");
Which causes the compiler to report a syntax error.
Change History (4)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to dylan |
Priority: | undecided → high |
Status: | new → assigned |
Fairly annoying bug for some users, will see if we can land this for 1.10.
comment:3 Changed 7 years ago by
Owner: | changed from dylan to Ed Hager |
---|
Actually, forgot, you're a committer now... giving this back to you. I'll just review the PR...
comment:4 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Added to master in commit 0a7f6b0172694f4012a1896537cecc0f43a93800.
Note: See
TracTickets for help on using
tickets.
Pull request: https://github.com/dojo/util/pull/21