Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17993 closed task (fixed)

Missing dom-style in define for dijit Select widget?

Reported by: karzelek Owned by: bill
Priority: undecided Milestone: 1.8.7
Component: Dijit - Form Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

I found something strange when using IE11 in IE8 mode. IE stopped on an exception telling me the line "var s=domStyle.getComputedStyle(this.domNode);" is wrong: "'domStyle' is undefined". (Which already surprised me. As it is the compressed .js file I would have supposed domStyle to be replaced by a shorter variable name.)

So I checked the define statement and different dojo/dom-... modules are loaded, but dojo/dom-style seems to not be loaded.

Change History (4)

comment:1 Changed 6 years ago by bill

Component: GeneralDijit - Form
Milestone: tbd1.8.7
Owner: set to bill
Status: newassigned
Type: defecttask
Version: 1.9.31.8.0

Good catch, indeed it is referencing domStyle but not require()'ing it. It's inside a if(has("ie") < 9) and then inside a try/catch so the error is squelched. Apparently this code is not very important. It's from d7e70e3dec1d4cfcb0d8fb5f6acf82f4f82f9e9e, refs #14850.

Last edited 6 years ago by bill (previous) (diff)

comment:2 Changed 6 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 67a0b5b5004d0b3950183543891cb9c0f24088ea/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by Bill Keese <bill@…>

In 189073dd71b0f4704850ad00b5e034945dc2ccae/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by Bill Keese <bill@…>

In e376930d3a33c0a76dcb255e485e0762b3a59586/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.