dijit/layout/BorderContainer is not rendered when gutters is false

[willchb]

When we set gutters to false, baseClass property is changed and the entire widget doesn't show at all. That happens in postMixInProperties. When gutters is false, baseClass becomes dijitBorderContainerNoGutter.

I can workaround the issue by just commenting out the line that changes baseClass. Even after commenting out that, it seems to work like expected, i.e. borders are not displayed for non-resizable content panes.

[bill]

It works fine for me, see the third example of ​http://downloads.dojotoolkit.org/release-1.9.3/dojo-release-1.9.3/dijit/tests/layout/test_BorderContainer.html.

If you have a test case that fails, write a comment back here and attach the test case.

[willchb]

Before it didn't work because I had this:

.dijitBorderContainer { 
	width: 100%;
	height: 100%;
}

Now I updated it as below and it worked:

.dijitBorderContainer, .dijitBorderContainerNoGutter { 
	width: 100%;
	height: 100%;
}

For more details, find my full code in attachments.

Anyway, CSS class dijitBorderContainerNoGutter doesn't affect anything at all. So at least for now, it's unnecessary. Also, it doesn't make sense to me that sometimes default baseClass of dijit/layout/BorderContainer is other than dijitBorderContainer.

The below snippet from dijit/layout/BorderContainer can be safely removed.

if(!this.gutters){
	this.baseClass += "NoGutter";
}

[bill]

OK, I guess you are right, I'll remove that. dijit.css also has references to .dijitBorderContainerNoGutter so they should be removed.

[Bill Keese <[email protected]…>]

In adfcd3bd30fae997a8cb8a3891b8c5aa324f1c76/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 56d3a146ea74e4a73fd8bbe8a510c7e18c9b0521/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 6aeb5dd99fb2a554ffc53e131baac0c856ed410a/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?