Deprecation of dojo.style doesn't actually work

[[email protected]…]

dojo.style was deprecated moving from 0.3.1 to 0.4, with the replacement for dojo.style.X() being dojo.html.X(). When you dojo.require() dojo.style in 0.4 the deprecation warning appears but dojo.style.X() functions fail to work.

quick patch (CCLA: One Track Mind Ltd.):

Index: src/style.js
===================================================================
--- src/style.js        (revision 6334)
+++ src/style.js        (working copy)
@@ -3,3 +3,4 @@
        browser: ["dojo.html.style"]
 });
 dojo.deprecated("dojo.style", "replaced by dojo.html.style", "0.5");
+dojo.style = dojo.html;

[alex]

not sure why we haven't knocked this down yet...it's pretty brutal.

[alex]

(In [6493]) fixes #1795

[[email protected]…]

While the deprecation warning says "use dojo.html.style" and that is the correct package to load, the style functions are actually methods of dojo.html, not dojo.html.style (which is an empty object).

So i think the fix should be something like:

dojo.lang.mixin(dojo.style, dojo.html); 

Maybe the deprecation message should change too?

[alex]

(In [6537]) fixes #1795

Thanks to Robert Coup for spotting the bogus fix that was committed earlier

[(none)]

Milestone 0.4.1 deleted