Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17944 closed defect (fixed)

error on combobox destroy

Reported by: bill Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.10
Component: DojoX Mobile Version: 1.10.0-beta1
Keywords: Cc:
Blocked By: Blocking:

Description

dojox/mobile's _Combobox and _ComboBoxMenu are setting bgIframe to true/false, rather than to a widget like it should be, thus causing errors on destroy.

See dijit/tests/form/AutoCompleterMixin.html for a failing test case. (Obviously the dijit tests should not be referencing code in dojox but that's an orthogonal issue.)

Change History (6)

comment:1 Changed 5 years ago by Adrian Vasiliu

Owner: set to Adrian Vasiliu
Status: newassigned

comment:2 Changed 5 years ago by Adrian Vasiliu

Milestone: tbd1.10
Version: 1.9.31.10.0-beta1

comment:3 Changed 5 years ago by Adrian Vasiliu

Okay, so the workaround I pushed some time ago (https://github.com/dojo/dojox/commit/ec0f7215887f1040b5348e04a185592643e2bea7) for dojox/mobile/ComboBox after the recent changes in dijit/popup doesn't cover the situation of this dijit test. A similar workaround is not applicable for this situation because the call of destroy() isn't triggered by the mobile combobox code itself.

Given that dijit/popup doesn't provide a clean way to opt out for the use (on some browsers) of dijit/BackgroundIframe, we modify the mobile combobox such that it doesn't try anymore to hack the opting out.

(Bill, I guess you entered version=1.9.3 because a 1.10 prerelease tag wasn't yet available - in any case at the best of my knowledge this issue doesn't hold for 1.9.3.)

comment:4 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: fixed
Status: assignedclosed

In 8470d88cf6c947f39c2477c19778f347b9203d6a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by bill

Bill, I guess you entered version=1.9.3 because a 1.10 prerelease tag wasn't yet available

Basically yes. I marked it as 1.9.3 because there's no choice for "trunk". 1.10-beta wouldn't have been an appropriate label either because 1.10-beta didn't exist at the time, and you might have fixed the bug before we cut the beta.

comment:6 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

In 9b6912b788de2d1f96e0132990dafc272b1651cf/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.