#17941 closed defect (fixed)
[patch][cla] dojox/widget/UpgradeBar is using deprecated dojo.cache and causes build to fail.
Reported by: | gaurav21r | Owned by: | dylan |
---|---|---|---|
Priority: | low | Milestone: | 1.10 |
Component: | DojoX Widgets | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The dojox/widget/UpgradeBar is using dojo.cache which is deprecated according to http://dojotoolkit.org/reference-guide/1.9/dojo/cache.html. The problem is in the following part of the file
templateString: cache("dojox.widget","UpgradeBar/UpgradeBar.html"),
This is also causing builds to fail because dojox/widget/UpgradeBar/UpgradeBar.html is getting required in the built layer.
The resolution is to easily replace it with dojo/text! which I've already done as a PR on github.
I have tested the solution with the test_UpgradeBar.html and test_UpgradeBar_markup.html files.
Change History (8)
comment:1 Changed 8 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to dylan |
Priority: | undecided → low |
Status: | new → assigned |
Summary: | dojox/widget/UpgradeBar is using deprecated dojo.cache and causes build to fail. → [patch][cla] dojox/widget/UpgradeBar is using deprecated dojo.cache and causes build to fail. |
comment:2 Changed 8 years ago by
comment:4 Changed 8 years ago by
@gaurav21r The 1.10 feature freeze deadline is Wednesday, so I'll look at it before end of Wednesday.
comment:5 Changed 8 years ago by
@dylan thanks! Btw any place where I can see these deadlines? Would really help in the future with fixes and patches.
comment:6 Changed 8 years ago by
@gaurav21r mostly via emails to dojo-contributors, and at the weekly Dojo meetings, e.g. https://bugs.dojotoolkit.org/wiki/ProjectMeeting/2014-04-30
comment:7 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:8 Changed 8 years ago by
Thank you @dylans! Can I also ask you to look at https://bugs.dojotoolkit.org/ticket/16935 ? Its been over a year and a half now and it would be great if we could do it in 1.10
The 100th Pull Request to Dojox has the resolution https://github.com/dojo/dojox/pull/100