[patch][cla] dojox/widget/UpgradeBar is using deprecated dojo.cache and causes build to fail.

[gaurav21r]

The dojox/widget/UpgradeBar is using dojo.cache which is deprecated according to http://dojotoolkit.org/reference-guide/1.9/dojo/cache.html. The problem is in the following part of the file

templateString: cache("dojox.widget","UpgradeBar/UpgradeBar.html"),

This is also causing builds to fail because dojox/widget/UpgradeBar/UpgradeBar.html is getting required in the built layer.

The resolution is to easily replace it with dojo/text! which I've already done as a PR on github.

I have tested the solution with the test_UpgradeBar.html and test_UpgradeBar_markup.html files.

[gaurav21r]

The 100th Pull Request to Dojox has the resolution ​https://github.com/dojo/dojox/pull/100

[gaurav21r]

@dylan May I request to merge the PR ASAP!?

[dylan]

@gaurav21r The 1.10 feature freeze deadline is Wednesday, so I'll look at it before end of Wednesday.

[gaurav21r]

@dylan thanks! Btw any place where I can see these deadlines? Would really help in the future with fixes and patches.

[dylan]

@gaurav21r mostly via emails to dojo-contributors, and at the weekly Dojo meetings, e.g. ​https://bugs.dojotoolkit.org/wiki/ProjectMeeting/2014-04-30

[dylans <dylan@…>]

In 6d7cf5e86e4baf50ecb1edb9d91777e98871dda8/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[gaurav21r]

Thank you @dylans! Can I also ask you to look at ​https://bugs.dojotoolkit.org/ticket/16935 ? Its been over a year and a half now and it would be great if we could do it in 1.10