Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17927 closed defect (fixed)

UserAgent CSS IE11 Support (uacss.js)

Reported by: kavitashah Owned by: bill
Priority: undecided Milestone: 1.7.9
Component: Core Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

This module fails to add IE11 specific css class to the <head>.

The attached patch addresses this issue for now.

When the next IE version comes out, this patch may need to be updated.

What is the recommended approach to address this issue?

Attachments (1)

dojo_uacss_dj_ie11.patch (419 bytes) - added by kavitashah 6 years ago.
Patch for uacss.js

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by kavitashah

Attachment: dojo_uacss_dj_ie11.patch added

Patch for uacss.js

comment:1 Changed 6 years ago by bill

I think the correct way to get the version of IE (including IE11+) is shown in https://github.com/dojo/dojo/commit/f58c0e19ce509398985908688a768c8fb41191b8.

I also noticed that the "trident version" of IE11 is 7, and I'm also not sure what the trident version will be for IE12.

Last edited 6 years ago by bill (previous) (diff)

comment:2 Changed 5 years ago by Alexander Kläser

Bill, I am a bit puzzled... the commit that you refer to has been reverted. With the current version of Dojo (1.10.4), dojo/uacss still does not add any IE11 specific CSS classes to the HTML tag. There is no way of assigning particular CSS rules to IE11 or am I wrong?

comment:3 Changed 5 years ago by bill

@alexklaeser, you are right. Since dojo has decided to set has("ie") undefined for IE11+, presumably we should add a dj_trident.

Out of curiousity what CSS rule do you need for IE11?

comment:4 Changed 5 years ago by bill

Milestone: tbd1.7.9
Owner: set to bill
Status: newassigned

Regardless, since this goes along with other IE11 support, I'll add it and backport to 1.7.

comment:5 Changed 5 years ago by bill

Resolution: fixed
Status: assignedclosed

OK, pushed in fb51eb64719aee71f7f1da1dce9efd75de717524, 660692a883f729470d846c7079eed839912a19e5, 751ac1e1d23dd4e58d804a07eec62b518ea8c24d, 129fcff4b541aa49f89cc30c6e4c67237a3680d7, ee1d1e0490c8bbe8dab5aba2c52afde523536a54.

comment:6 Changed 5 years ago by bill

Note: A CSS rule just for IE11 should be:

.dj_trident7 ... {
...
}

comment:7 in reply to:  3 Changed 5 years ago by Alexander Kläser

Replying to bill:

@alexklaeser, you are right. Since dojo has decided to set has("ie") undefined for IE11+, presumably we should add a dj_trident.

Thanks for your answer, Bill! Yes, that was the conclusion that I came to, as well, after reading the following article about IE11:

http://www.nczonline.net/blog/2013/07/02/internet-explorer-11-dont-call-me-ie/

Thus I added exactly the same patch yesterday evening to our system that you were committing now ;) .

Out of curiousity what CSS rule do you need for IE11?

Our bug with IE11 is documented here:

https://forge.univention.org/bugzilla/show_bug.cgi?id=38225

We observed some display problems with IE11 and SVG graphics :( . Under some obscure circumstances, SVG background graphics were selectively not displayed. I decided to use PNG graphics for IE9+ instead, as I could not find any other sensible workaround. This problem seems to be connected to the following one documented here:

https://connect.microsoft.com/IE/feedback/details/794664/svg-display-issues-with-ie-11

comment:8 Changed 5 years ago by bill

Ah I see, interesting bug. I was hoping IE11 wouldn't need any such workarounds, but I guess it doesn.

comment:9 in reply to:  8 Changed 5 years ago by Alexander Kläser

Replying to bill:

Ah I see, interesting bug. I was hoping IE11 wouldn't need any such workarounds, but I guess it doesn.

Me too... but I guess, that there will always be problems to run into, otherwise life in a perfect world would be too easy :) .

Last edited 5 years ago by Alexander Kläser (previous) (diff)
Note: See TracTickets for help on using tickets.