Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17898 closed defect (patchwelcome)

columnReordering - Width of columns messed up

Reported by: GuyT07 Owned by:
Priority: undecided Milestone: tbd
Component: DojoX Grid Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

When I use a grid(doesn't mind which one) and I set columnReordering to true the column grid will be messed up after you've changed the width of a column(header width != column width).

See my jsFiddle for a detailed example: http://jsfiddle.net/qKjm7/8/

The only thing you have to do is change the size of a column.

Note: I know that the community wants that we use the dgrid or jqgrid instead of the default Dojo grids, but in my opinion the EnhancedGrid? has a lot more to offer and has some features I need in my currenct project.

Change History (4)

comment:1 Changed 5 years ago by dylan

Resolution: patchwelcome
Status: newclosed

It's not that we just want you to use them, it's that dojox/grid/DataGrid and dojox/grid/EnhancedGrid are deprecated as of 1.9 and no longer actively maintained.

If you have a patch, we'll review and apply it, but otherwise we encourage you to try dgrid or gridx.

EnhancedGrid? really suffers from trying to do too much, replicating toolkit features that you can find in other packages, instead of just relying on things that already exist. Don't fall for the classic "more features" over quality argument, pretty much every feature from EnhancedGrid? can be achieved with dgrid or gridx, and more efficiently.

comment:2 Changed 5 years ago by GuyT07

  • removed -
Last edited 5 years ago by GuyT07 (previous) (diff)

comment:3 in reply to:  1 Changed 5 years ago by GuyT07

Replying to dylan:

It's not that we just want you to use them, it's that dojox/grid/DataGrid and dojox/grid/EnhancedGrid are deprecated as of 1.9 and no longer actively maintained.

If you have a patch, we'll review and apply it, but otherwise we encourage you to try dgrid or gridx.

EnhancedGrid? really suffers from trying to do too much, replicating toolkit features that you can find in other packages, instead of just relying on things that already exist. Don't fall for the classic "more features" over quality argument, pretty much every feature from EnhancedGrid? can be achieved with dgrid or gridx, and more efficiently.

I get that. Are there any future plans to integrate the dgrid into the default dojo(x) packages? At the moment I'm diving into the dgrid, but everything needs to be done with plugins. You can't even use the dijit registry to get the grid(because it isn't really a widget) until you use dgrids registry plugin.

comment:4 Changed 5 years ago by GuyT07

I have fixed it by disabling the padding:

.tundra .dojoxGridRowTable .dojoDndHorizontal th.dojoDndItem{
	padding: 0 !important;
}

This was also on the normal grid. Maybe someone could use it(or even update it in the dojo source).

Note: See TracTickets for help on using tickets.