#17870 closed enhancement (wontfix)
[PATCH] [CLA] dojo/_base/unload should return handles
| Reported by: | iDo | Owned by: | |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.10 |
| Component: | Core | Version: | 1.9.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
addOnWindowUnload and addOnUnload should return a handle so we can
disconnect the event if needed.
However, according to this ticket #16585 dojo/_base/unload is deprecated, but the code and the live docs still refer to it...
So I wonder, is it deprecated (and then my patch can be ignored) ?
See pull request : https://github.com/dojo/dojo/pull/78
Change History (3)
comment:1 Changed 6 years ago by
| Milestone: | tbd → 1.10 |
|---|
comment:2 Changed 6 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
OK, we decided to just document those methods as deprecated. Thanks anyway for the patch.
Note: See
TracTickets for help on using
tickets.
I thought they were deprecated, but they aren't explicitly marked as deprecated, so I don't really care if we check in that trivial patch. Any other opinions?