dojo gantt chart calendar starts from sunday

[manju]

hi Dojo gantt chart calendar starts from Sunday and ends with saturday. this dates are not sinking with weekend highlighted by dojox ganttChart. is it a bug or i need to change something? please refer below URL and screenshot ​​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/gantt/tests/test_Gantt.html Thanks

[ben hockey]

#17833 is a duplicate of this ticket.

[freddefisk]

Hmm... I don't understand your screen shot. It says "Feb 17 th 2012 is Sunday", which it's not. I guess you really mean June, as this is also the active month in the screen shot.

[freddefisk]

The error is in addDayInPanelTime (​https://github.com/dojo/dojox/blob/1.9.3/gantt/GanttChart.js#L929), where the weekend is checked by doing date.getDay() >= 5, however Saturday is represented by 6 and Sunday by 0 (​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getDay), so the current implementation will always mark Friday and Saturday as the weekend.

The fix is probably just to change (date.getDay() >= 5) to (date.getDay() == 0 || date.getDay() == 6).

[manju]

i have tried the above code. Now dates are sinking with weekend highlighted by dojox ganttChart. but still i am not able to add saturday as weekend.

we can add either sunday or saturday as weekend but not both.

so please let me know how to get saturday and sunday as weekends with dates sinking with calendar

Thanks Manjunath

[dylan]

Given that no one has shown interest in creating a patch in more than a year, I'm closing this as patchwelcome. Please let us know if you would like to get involved in helping make this change to Dojo!