dojo.global doesn't point to window w/latest RequireJS

[bill]

dojo/_base/kernel.js defines dojo.global as this:

define(["../has", "./config", "require", "module"], function(has, config, require, module){
... 
        dojo = {
            global:this,
            ...
        };
...

The meaning of this in AMD callbacks is apparently not defined, and starting with ​jrburke/[email protected], RequireJS ​sets it to the exports object rather than to window.

This will break various things in dojo, such as dojo.getObject() and the parser handling globals, ex: <div data-dojo-type=dijit/Tree store=globalStore>.

Probably we should get the real global object via (function(){ return this; })() rathern than this.

[bill]

PS: posted ​https://groups.google.com/forum/#!topic/amd-implement/OkUXYTAgCwM for discussion about the RequireJS behavior.

[Colin Snover <[email protected]…>]

In 27533ab2144f77ecd5baebc7be1b079ca2446aef/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 1fee2371205ed90bfbb48faf393758dfe0268ff3/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 523c19d973187e8966ca7c954c5b48d5bc0f371e/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 4a9fb88f4ed230f10a741e2c8745b491c374e575/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 45049b9648dac95d9ba0f23eb090d7794bb9473b/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[bill]

Thanks for the fixes.

Looks like the important change is actually in ​https://github.com/dojo/dojo/commit/fa4028b647e38d4f1cc183e6db65022f80cb5423 (and probably backports too).