Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17825 closed defect (fixed)

dojox/mobile/ListItem keydown handler is called twice

Reported by: Patrick Ruzand Owned by: Patrick Ruzand
Priority: high Milestone: 1.10
Component: DojoX Mobile Version: 1.9.3
Keywords: a11y Cc:
Blocked By: Blocking:

Description

The dojox/mobile/ListItem keydown handler is called twice when a key is pressed.

This is a regression comming from the #16133 fix (​https://github.com/dojo/dojox/commit/6f53da7427b9bbdc2ba595bf6649ba7fc9da4a3b): a listener is set on 'keydown' in ListItem?.startup() a first time, then in _updateHandles() a second time (ListItem?._updateHandles() is called via the ItemBase?.startup() inherited call ).

The fix is to remove the code registring the keydown handler from the ListItem?.startup() method.

Change History (3)

comment:1 Changed 5 years ago by Patrick Ruzand

Keywords: a11y added
Milestone: tbd → 1.10
Owner: set to Patrick Ruzand
Priority: undecided → high
Status: new → assigned

comment:2 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: → fixed
Status: assigned → closed

In 62218835968063aed384b2d0291c672fbb7183dc/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:3 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

In 2c4ba4d9ad64f97491698580baa06f6c72c42f7f/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.