Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#17822 closed defect (fixed)

dojox/mobile/scrollable: in some conditions, onFlickAnimationStart/End() are not properly triggered

Reported by: Adrian Vasiliu Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.9.4
Component: DojoX Mobile Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adrian Vasiliu)

Depending on the scrollType and browser, dojox/mobile/scrollable.onFlickAnimationStart/End() may be improperly triggered:

  • either onFlickAnimationStart() is not called at all (holds for all browsers with scrollType 2 or 3), or
  • onFlickAnimationEnd() is triggered twice instead of once (holds with scrollType 2 for Safari on iOS 7, but not for Chrome on desktop or Android 4.4, for instance).

This issue hurts in some conditions for the behavior of widgets using dojox/mobile/scrollable, such as SpinWheel? and SwapView?.

How to reproduce: run the DOH unit test attached to the (upcoming) pool request.

Change History (11)

comment:1 Changed 6 years ago by Adrian Vasiliu

Description: modified (diff)

comment:3 Changed 6 years ago by Adrian Vasiliu

Milestone: tbd1.10

comment:4 Changed 6 years ago by Adrian Vasiliu

Owner: set to Adrian Vasiliu
Status: newassigned

comment:5 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: fixed
Status: assignedclosed

In be1d58bedd7db784d6ad70e56949d4c80cd6bdbe/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

In a627bbc99958d0b21df57972a0560cd2568a47ee/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 6 years ago by Adrian Vasiliu

Milestone: 1.101.9.4

comment:8 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

In ab5ea219374e503a2d384940d6518a7f061aac17/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by Adrian Vasiliu <vasiliu@…>

In 529dc0c20b036acdb1cf3a2f6fbc131ed52ab58d/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by Adrian Vasiliu

The above commits fix a number of other cases when onFlickAnimationStart/End() were not properly paired, and which were not properly detected by the DOH test.

This commit includes:

  • Another change in dojox/mobile/scrollable to also fix the start/end notifications for browsers not supporting css3 animations (where dojox/fx is used).
  • A fix in the DOH test to require dojox/fx (in the current design, dojox/mobile/scrollable uses them only for browsers without css3 animation and leaves the responsibility for requiring the modules on the user).
  • Another fix in the DOH test: a missing "return" statement in one of the test cases was hiding errors in some browsers.

comment:11 Changed 5 years ago by Bill Keese <bill@…>

In fc11ab64523ca3eb08d5eedf82b979d086b06eff/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.