Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17818 closed defect (fixed)

dijit doh tests failing on Chrome 33 / Windows 7

Reported by: Sebastien Brunot Owned by: bill
Priority: undecided Milestone: 1.9.4
Component: Dijit Version:
Keywords: Cc:
Blocked By: Blocking:

Description

The following doh tests are failing on dijit master branch when run in Chrome 33 on Windows 7:

form.test_validate: 5 failures layout.ContentPaneLayout?: 5 failures

Change History (8)

comment:1 Changed 6 years ago by bill

dijit/tests/form/test_validate.html?mode=test runs w/out failure for me on Chrome 33 / Win 7. Does it fail for you standalone?

comment:2 Changed 6 years ago by bill

Owner: set to Sebastien Brunot
Status: newpending

Also, layout.ContentPaneLayout? works, but you need to enable PHP on your webserver. This is true for a number of the dijit tests.

comment:3 Changed 6 years ago by Sebastien Brunot

Status: pendingnew

I ran dijit/tests/form/test_validate.html?mode=test and got 6 failures, most of them presumably related to the locale of my computer:

FAILURE 1:

_AssertFailure: assertEqual() failed: expected

3,000

but got

3 000

with hint:

elevation display value

FAILURE 2:

_AssertFailure: assertEqual() failed:

expected

1,234

but got

1 234

with hint:

focusNode.value

FAILURE 3:

_AssertFailure: assertEqual() failed: expected

$1,234.00

but got

$US1,234.00

with hint:

focusNode.value

FAILURE 4:

_AssertFailure: assertEqual() failed:

expected

true

but got

false

with hint:

isValid()

FAILURE 5:

_AssertFailure: assertEqual() failed:

expected

1.62500

but got

1,62500

with hint:

formatted displayed value

FAILURE 6:

_AssertFailure: assertEqual() failed:

expected

1.125

but got

1,125

with hint:

formatted displayed value

comment:4 Changed 6 years ago by bill

Milestone: tbd1.9.4
Owner: changed from Sebastien Brunot to bill
Status: newassigned

I see, yes, unfortunately the tests break when run in a different locale. I imagine there are even more problems when using an RTL locale. I will update the test to hardcode en-us as the locale.

comment:5 Changed 6 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 60858ffa07b81e14172e63f31985dca0d710727e/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 6 years ago by Bill Keese <bill@…>

In 5e41a7b2e70fcf2e2c81111f83124d9c066688f8/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 6 years ago by Bill Keese <bill@…>

In 2dc1d9bb1219dc12ee2ae29d1eab1bdc7a71f0c5/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 6 years ago by Bill Keese <bill@…>

In ba5e4e50d35b1480ad8605a80418b0dbd75d8475/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.