Opened 5 years ago

Closed 5 years ago

#17809 closed defect (fixed)

[patch][cla] Dojo build doesn't work with the latest Closure Compiler

Reported by: agavrilov Owned by: Colin Snover
Priority: blocker Milestone: 1.10
Component: BuildSystem Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

We are using Closure Compiler to make a custom Dojo build.

When I replaced compiler.jar file in util/closureCompiler folder with the latest version from https://developers.google.com/closure/compiler/, Dojo build started to report ClassNotFound? exceptions about com.google.javascript.jscomp.JSSourceFile.

As turns out, they removed JSSourceFile class. You need to use SourceFile? class instead. When I replaced JSSourceFile in util/build/transforms/optimizer/closure.js on the line 40 with just SourceFile?, Dojo build started to work again.

Change History (5)

comment:1 Changed 5 years ago by dylan

Milestone: tbd1.10
Owner: set to Rawld Gill
Priority: undecidedblocker
Status: newassigned

comment:2 Changed 5 years ago by agavrilov

comment:3 Changed 5 years ago by dylan

Summary: Dojo build doesn't work with the latest Closure Compiler[patch][cla] Dojo build doesn't work with the latest Closure Compiler

comment:4 Changed 5 years ago by dylan

Owner: changed from Rawld Gill to Colin Snover

comment:5 Changed 5 years ago by Colin Snover

Resolution: fixed
Status: assignedclosed

Fixed in 5560ac3ef5eeed782118dec180be444d8695645e

Note: See TracTickets for help on using tickets.