Opened 6 years ago
Last modified 3 years ago
#17801 assigned defect
[patch][cla] Convert dojox/image/* and dojox/widget/RollingList to AMD
Reported by: | dylan | Owned by: | bpayton |
---|---|---|---|
Priority: | high | Milestone: | 1.15 |
Component: | DojoX Widgets | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Change History (10)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
Milestone: | 1.10 → 1.11 |
---|---|
Owner: | set to bpayton |
Status: | new → assigned |
comment:3 Changed 6 years ago by
Milestone: | 1.11 → 1.10 |
---|
comment:4 Changed 6 years ago by
Owner: | changed from bpayton to dylan |
---|
comment:5 Changed 6 years ago by
Owner: | changed from dylan to bpayton |
---|
comment:6 Changed 6 years ago by
Milestone: | 1.10 → 1.11 |
---|
Based on my review of this pull request, I'm moving this to 1.11 as it needs more work to follow modern best practices.
comment:7 Changed 5 years ago by
I started working on this at https://github.com/dylans/dojox/commit/45aadee635b8a2d890f8902dcbebcc29eb44a333
Current state:
dojox/image/
- Some of the tests still need to be updated, as they use very old code
- Still uses dojo/data
- FlickrRestStore? is broken in chrome (seems to be failing JSONP)
- VerticalThumbnailPicker? doesn't scroll (this wasn't working in the tests prior to this refactor either)
- several other modules in dojox/image have not been converted yet
dojox/widget/RollingList
- Still uses dojo/data
- Working on updating the test case still
- Test is not yet working
comment:8 Changed 5 years ago by
A bit more progress on this. Current state in my branch:
dojox/image:
- Tests and code are updated for some of dojox/image, except for the following: FlickrBadge?, Badge, Lightbox, Magnifier, MagnifierLite?, and _base.js (and their associated tests)
- FlickRestStore? doesn't work in Chrome except when served from SSL due to its use of JSONP
- VerticalThumbnailPicker? does not scroll
- Still uses dojo/data
dojox/widget/RollingList:
- Still uses dojo/data
- Test case has been updated, but does not work yet as the conversion has broken several capabilities in subtle ways that need to be worked through
- The call structure of at least a few methods it not correct at the moment
comment:9 Changed 4 years ago by
Milestone: | 1.11 → 1.12 |
---|
comment:10 Changed 3 years ago by
Milestone: | 1.13 → 1.15 |
---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
Note: See
TracTickets for help on using
tickets.
if we want to keep it for 1.10, we should have an assignee on that one, otherwise remove the version number?