Opened 7 years ago
Closed 7 years ago
#17776 closed defect (fixed)
Demos busted on http://demos.dojotoolkit.org/demos/
Reported by: | Pete Smith | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.10 |
Component: | Documentation | Version: | 1.9.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
http://demos.dojotoolkit.org/demos/i18n/demo.html
and
http://demos.dojotoolkit.org/demos/form/demo.html
clearly, there is some css missing. In Firefox the menus are not hidden and the text boxes are a mess.
Change History (11)
comment:1 Changed 7 years ago by
Milestone: | tbd → 1.10 |
---|---|
Owner: | set to cjolif |
Priority: | undecided → high |
Status: | new → assigned |
comment:2 Changed 7 years ago by
Owner: | changed from cjolif to dylan |
---|
comment:3 Changed 7 years ago by
Did you use the build with the demos-all profile?
IIRC, dijit.css intentionally isn't inlined because that would cause a repeat between the themes (for pages that load multiple themes). But I can't explain why it's inlined for you and not on the demo site. Maybe the settings were changed recently.
comment:5 Changed 7 years ago by
OK... but did you use build_demos.sh?
It has this line:
cssImportIgnore=../dijit.css,../resources/demos.css \
Hence dijit.css is not inlined into demos.css.
comment:6 Changed 7 years ago by
As discussed in the meeting, we are generating CSS with an @import statement in the middle of the file, which is invalid CSS.
comment:7 Changed 7 years ago by
Owner: | changed from dylan to cjolif |
---|
Handing back to cjolif based on discussion during the meeting.
comment:8 Changed 7 years ago by
The fix is to do at least one of the following, maybe both:
- remove the
cssImportIgnore=../dijit.css,../resources/demos.css
line from build_demos.sh - push https://github.com/dojo/util/pull/17
comment:9 Changed 7 years ago by
https://github.com/dojo/util/pull/17 has been committed, so just rebuilding should fix that one.
comment:10 Changed 7 years ago by
Owner: | changed from cjolif to dylan |
---|
comment:11 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This is fixed and live.
this is working for me locally either in unbuilt or built form. Looking at what differs from the server it looks like in the version deployed on the server the @import in CSS of those two demos is not fully inlined in the demo.css (there is some @import url("../../dijit/themes/dijit.css"); still here). That I guess can explain the difference. I would suggest trying to rebuild the demo and see how things are going (maybe there was a build bug that was fixed in between)?