Demos busted on http://demos.dojotoolkit.org/demos/

[Pete Smith]

​http://demos.dojotoolkit.org/demos/i18n/demo.html

and

​http://demos.dojotoolkit.org/demos/form/demo.html

clearly, there is some css missing. In Firefox the menus are not hidden and the text boxes are a mess.

[cjolif]

this is working for me locally either in unbuilt or built form. Looking at what differs from the server it looks like in the version deployed on the server the @import in CSS of those two demos is not fully inlined in the demo.css (there is some @import url("../../dijit/themes/dijit.css"); still here). That I guess can explain the difference. I would suggest trying to rebuild the demo and see how things are going (maybe there was a build bug that was fixed in between)?

[bill]

Did you use the build with the demos-all profile?

IIRC, dijit.css intentionally isn't inlined because that would cause a repeat between the themes (for pages that load multiple themes). But I can't explain why it's inlined for you and not on the demo site. Maybe the settings were changed recently.

[cjolif]

yes I did build with the demos-all profile.

[bill]

OK... but did you use build_demos.sh?

It has this line:

cssImportIgnore=../dijit.css,../resources/demos.css \

Hence dijit.css is not inlined into demos.css.

[dylan]

As discussed in the meeting, we are generating CSS with an @import statement in the middle of the file, which is invalid CSS.

[dylan]

Handing back to cjolif based on discussion during the meeting.

[bill]

The fix is to do at least one of the following, maybe both:

1. remove the cssImportIgnore=../dijit.css,../resources/demos.css line from build_demos.sh
2. push ​https://github.com/dojo/util/pull/17

[cjolif]

​​https://github.com/dojo/util/pull/17 has been committed, so just rebuilding should fix that one.

[dylan]

This is fixed and live.