Opened 6 years ago

Last modified 2 years ago

#17772 assigned enhancement

Should dojo/store/Cache return in-flight promises?

Reported by: psbucky Owned by: dylan
Priority: low Milestone: 1.14
Component: Data Version: 1.9.3
Keywords: Cc:
Blocked By: Blocking:

Description

I was thinking that the dojo/store/Cache should return any in-flight requests to the master Store.

The following small change works for me in my situation. I was thinking it could work for others.

Attachments (1)

Cache.diff (1.2 KB) - added by psbucky 6 years ago.
Change to Cache.js that returns in-flight promises.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by psbucky

Attachment: Cache.diff added

Change to Cache.js that returns in-flight promises.

comment:1 Changed 5 years ago by Wouter Hager

+1

I think this should be flagged as defect instead of enhancement.

comment:2 Changed 5 years ago by bill

Component: GeneralData
Owner: set to Kris Zyp

I don't understand what bug you are trying to fix.

comment:3 Changed 5 years ago by Wouter Hager

In my application a lot of links have to be requested for different purposes. When I use JsonRest? store with Cache, the links are not yet resolved by the time consecutive requests are made, and so the same links are requested. This simply results in unnecessary traffic.

comment:4 Changed 5 years ago by bill

Ah I see, makes sense. I guess it's hard to automatically test (without fancy things like stubs), but sounds like a good idea.

comment:5 Changed 4 years ago by dylan

Milestone: tbd1.11
Owner: changed from Kris Zyp to dylan
Status: newassigned

I'll review this soon and consider it for Dojo 1.11.

comment:6 Changed 4 years ago by dylan

Priority: undecidedlow

comment:7 Changed 4 years ago by dylan

Milestone: 1.111.12

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

comment:8 Changed 3 years ago by dylan

Milestone: 1.121.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:9 Changed 2 years ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.