Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#17765 closed defect (fixed)

dijit/Tree - TreeNode focus can break expando/plus click handler

Reported by: Mangala Sadhu Sangeet Singh Khalsa Owned by: bill
Priority: blocker Milestone: 1.9.4
Component: Dijit Version: 1.9.2
Keywords: Cc:
Blocked By: Blocking:

Description

The fix for #17347 introduced a problem in IE (only tested in, and observed in IE8 and IE11).

If a node in the tree has a label that extends past the right edge of the tree (triggering horizontal scrolling), when you click the expando node, the a11yclick.press handler focuses the TreeNode? widget. In Firefox and Chrome, focusing does not cause scrolling. In IE, focusing scrolls the label (the focusNode) into view. This happens before the click handler for the expando node is called, and now the node under the mouse is no longer the expando node, so the value of event.target is incorrect and the node is not expanded.

See attached test case - problem occurs in Dojo 1.9.2 and 1.9.3.

Attachments (1)

ie-10-11-tree.html (1.4 KB) - added by Mangala Sadhu Sangeet Singh Khalsa 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Mangala Sadhu Sangeet Singh Khalsa

Attachment: ie-10-11-tree.html added

comment:1 Changed 6 years ago by Colin Snover

Milestone: tbd1.9.4
Owner: set to bill
Priority: undecidedblocker
Status: newassigned

PR: https://github.com/dojo/dijit/pull/25

Bill could you please review? Thanks.

comment:2 Changed 6 years ago by bill

Colin - Cool, looks good to me, thanks for the fix and the test.

comment:3 Changed 6 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: assignedclosed

In 6b973fbf125199d03f9e957175ea7c61da4f18c3/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by Colin Snover <github.com@…>

In bb512126abf359125c257db3d8b1be557186c0d8/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.